Add ARO classic (ARO-RP) prow jobs to sippy config

[abiduke612]

With Classic now using prow jobs as well, we want that data available via Sippy.

Added the following jobs to config:

aro-classic-integration:
  jobs:
    periodic-ci-Azure-ARO-RP-master-periodic-integration-e2e-parallel-csp: true
    periodic-ci-Azure-ARO-RP-master-periodic-integration-e2e-parallel-miwi: true
aro-classic-stage:
  jobs:
    periodic-ci-Azure-ARO-RP-master-periodic-stage-e2e-parallel-csp: true
    periodic-ci-Azure-ARO-RP-master-periodic-stage-e2e-parallel-miwi: true
aro-classic-production:
  jobs:
    periodic-ci-Azure-ARO-RP-master-periodic-prod-e2e-parallel-csp: true
    periodic-ci-Azure-ARO-RP-master-periodic-prod-e2e-parallel-miwi: true

Summary by CodeRabbit

• Chores
  • Reorganized deployment configuration for Azure Red Hat OpenShift environments.
  • Added new environment-specific configurations for classic deployments across integration, stage, and production.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

This PR restructures ARO CI/CD job configurations by removing three Azure HCP production jobs from aro-production and introducing three new top-level sections (aro-classic-integration, aro-classic-stage, aro-classic-production), each containing two parallel job variants with RP-master identifiers.

Changes

Configuration Restructuring

Layer / File(s)	Summary
Job Configuration Reorganization config/openshift-customizations.yaml	Three ARO HCP main production jobs removed from aro-production. Three new top-level sections added: aro-classic-integration, aro-classic-stage, and aro-classic-production. Each section contains two parallel job entries (csp and miwi variants) with updated RP-master identifiers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 16 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Go Error Handling	⚠️ Warning	PR adds 250+ Go files with 4,472+ ignored errors without justification, panic() calls outside init, and unsafe json.Marshal error ignores.	Properly handle ignored errors: wrap with fmt.Errorf %w, add justifications, replace panic() with error returns, verify nil checks before pointer dereferences.

✅ Passed checks (16 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the main change: adding ARO Classic prow jobs to sippy configuration, which matches the core objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Sql Injection Prevention	✅ Passed	PR contains only YAML config file changes adding job names. No code modifications that could introduce SQL injection vulnerabilities. Configuration data is not directly concatenated into SQL queries.
Excessive Css In React Should Use Styles	✅ Passed	Check not applicable. PR modifies YAML configuration file (config/openshift-customizations.yaml) only. Custom check applies to React component styling patterns, which are not present in this PR.
Test Coverage For New Features	✅ Passed	Configuration-only change. PR adds prow job configurations to YAML file. No code, functions, or logic. Explicitly exempt per check rules.
Single Responsibility And Clear Naming	✅ Passed	Check applies to code structures (packages, structs, methods). This PR modifies only a YAML configuration file defining Prow job groupings, not code.
Stable And Deterministic Test Names	✅ Passed	PR only modifies a YAML configuration file with prow job names. No Ginkgo test code is present. Check is not applicable.
Test Structure And Quality	✅ Passed	Check designed for Ginkgo test code. PR modifies only config/openshift-customizations.yaml with prow job entries. No test code present, so check is not applicable.
Microshift Test Compatibility	✅ Passed	PR adds only YAML configuration for prow jobs in config/openshift-customizations.yaml. No new Ginkgo e2e tests are added. The check requires new test code to be present.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only YAML config in sippy (a prow test analysis tool). No new Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies Sippy configuration file, not deployment manifests or operator code. Topology-aware scheduling check does not apply.
Ote Binary Stdout Contract	✅ Passed	PR only modifies YAML config file. OTE Stdout Contract check applies to code stdout writes. No code changes present, so not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only YAML configuration files. No Ginkgo e2e test code is added. The check only applies when new tests are added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abiduke612
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @abiduke612. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/openshift-customizations.yaml`:
- Around line 41-52: Presubmits pseudorelease's regex currently only matches
^pull-ci-Azure-ARO-HCP-main.* and therefore misses ARO Classic pull jobs; update
the Presubmits regexp list to include ^pull-ci-Azure-ARO-RP-master.* so
pull-ci-Azure-ARO-RP-master-images and other RP-master pull jobs are matched and
surface in Sippy alongside the added periodic jobs; locate the Presubmits entry
(symbol: Presubmits) and append the ^pull-ci-Azure-ARO-RP-master.* pattern to
its regex array.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2e69c475-c1cd-484d-a3b1-5aead626cf15

📥 Commits

Reviewing files that changed from the base of the PR and between 3f4f9ff and 6996f0a.

📒 Files selected for processing (1)

• config/openshift-customizations.yaml

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Current Presubmits config:"
sed -n '16,22p' config/openshift-customizations.yaml

echo
echo "ARO Classic pull jobs currently exposed by prow:"
curl -fsSL https://prow.ci.openshift.org/prowjobs.js \
  | rg -o 'pull-ci-Azure-ARO-RP-master[^"]*' \
  | sort -u

Repository: openshift/sippy

Length of output: 1326

---

Add ARO-RP-master pull jobs to the Presubmits pattern.

The Presubmits pseudorelease (line 21) still only matches ^pull-ci-Azure-ARO-HCP-main.*. However, prow contains pull-ci-Azure-ARO-RP-master-images pull jobs for ARO Classic that are not currently covered. Add ^pull-ci-Azure-ARO-RP-master.* to the Presubmits regexp list to ensure Classic pull job results surface in Sippy alongside the periodic jobs added in lines 41–52.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/openshift-customizations.yaml` around lines 41 - 52, Presubmits
pseudorelease's regex currently only matches ^pull-ci-Azure-ARO-HCP-main.* and
therefore misses ARO Classic pull jobs; update the Presubmits regexp list to
include ^pull-ci-Azure-ARO-RP-master.* so pull-ci-Azure-ARO-RP-master-images and
other RP-master pull jobs are matched and surface in Sippy alongside the added
periodic jobs; locate the Presubmits entry (symbol: Presubmits) and append the
^pull-ci-Azure-ARO-RP-master.* pattern to its regex array.

[stbenjam]

Does this release exist yet?