-
Notifications
You must be signed in to change notification settings - Fork 135
update the alert runbook to guide 4.13+ clusters to expand network range #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| ### For clusters running with version 4.13+ | ||
|
|
||
| User can follow the OpenShift doc to expand the network IP address range. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 'document' instead of 'doc'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of 'network IP address range', we should say 'cluster subnet IP address range'.
| Choosing a larger cluster network CIDR which can hold more subnets could prevent | ||
| this happening. | ||
|
|
||
| ### For clusters running with version 4.13+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use 'onward' instead of using '+' to imply later versions?
|
|
||
| User can follow the OpenShift doc to expand the network IP address range. | ||
|
|
||
| Refer: https://docs.redhat.com/en/documentation/openshift_container_platform/4.13/html/networking/configuring-cluster-network-range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this link remains true for all versions? If not, we can probably point to the release note mention for this change.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
@bmeng: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.