Skip to content

OCPBUGS-84323: log the reason why dcm failed #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcmoraisjr wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

OCPBUGS-84323: log the reason why dcm failed #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/router/template/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ func (r *templateRouter) dynamicallyAddRoute(backendKey ServiceAliasConfigKey, r

err := r.dynamicConfigManager.AddRoute(backendKey, backend.RoutingKeyName, route)
if err != nil {
log.V(4).Info("router will reload as the ConfigManager could not dynamically add route for backend", "backendKey", backendKey, "error", err)
log.V(0).Info("router will reload as the ConfigManager could not dynamically add route for backend", "backendKey", backendKey, "error", err)
return false
}

Expand All @@ -818,7 +818,7 @@ func (r *templateRouter) dynamicallyAddRoute(backendKey ServiceAliasConfigKey, r
weight = 0
}
if err := r.dynamicConfigManager.ReplaceRouteEndpoints(backendKey, oldEndpoints, newEndpoints, weight); err != nil {
log.V(4).Info("router will reload as the ConfigManager could not dynamically replace endpoints for route backend",
log.V(0).Info("router will reload as the ConfigManager could not dynamically replace endpoints for route backend",
"backendKey", backendKey, "serviceKey", key, "error", err)
return false
}
Expand All @@ -844,7 +844,7 @@ func (r *templateRouter) dynamicallyRemoveRoute(backendKey ServiceAliasConfigKey
log.V(4).Info("dynamically removing route backend", "backendKey", backendKey)

if err := r.dynamicConfigManager.RemoveRoute(backendKey, route); err != nil {
log.V(4).Info("router will reload as the ConfigManager could not dynamically remove route backend", "backendKey", backendKey, "error", err)
log.V(0).Info("router will reload as the ConfigManager could not dynamically remove route backend", "backendKey", backendKey, "error", err)
return false
}

Expand Down Expand Up @@ -923,7 +923,7 @@ func (r *templateRouter) dynamicallyReplaceEndpoints(id ServiceUnitKey, service
log.V(4).Info("dynamically replacing endpoints for associated backend", "backendKey", backendKey, "newEndpoints", newEndpoints)
if err := r.dynamicConfigManager.ReplaceRouteEndpoints(backendKey, oldEndpoints, newEndpoints, weight); err != nil {
// Error dynamically modifying the config, so return false to cause a reload to happen.
log.V(4).Info("router will reload as the ConfigManager could not dynamically replace endpoints for service", "service", id, "backendKey", backendKey, "weight", weight, "error", err)
log.V(0).Info("router will reload as the ConfigManager could not dynamically replace endpoints for service", "service", id, "backendKey", backendKey, "weight", weight, "error", err)
return false
}
}
Expand All @@ -950,7 +950,7 @@ func (r *templateRouter) dynamicallyRemoveEndpoints(service ServiceUnit, endpoin
log.V(4).Info("dynamically removing endpoints for associated backend", "backendKey", backendKey)
if err := r.dynamicConfigManager.RemoveRouteEndpoints(backendKey, endpoints); err != nil {
// Error dynamically modifying the config, so return false to cause a reload to happen.
log.V(4).Info("router will reload as the ConfigManager could not dynamically remove endpoints for backend", "backendKey", backendKey, "error", err)
log.V(0).Info("router will reload as the ConfigManager could not dynamically remove endpoints for backend", "backendKey", backendKey, "error", err)
return false
}
}
Expand Down