Warning that RPM install won't work on interactive PR

Add the sed -ie 's/restrict_network_access: false/restrict_network_access: true/' directions to the script output.
This means the RPM upload won't work because the undercluster won't have network access
Added a warning to script & docs about this

Signed-off-by: Tom Buskey <tbuskey@redhat.com>

Author: tbuskey

ci-operator/step-registry/sandboxed-containers-operator/create-prowjob/README.md

@@ -7,7 +7,7 @@
 The `sandboxed-containers-operator-create-prowjob-commands.sh` script creates prowjob configuration files.  These prowjobs contain variations of provider/workload combinations.  We will start with [Creating Prowjobs](#creating-prowjobs) and [Running Prowjobs](#running-prowjobs).  More detail starts in [General Usage](#general-usage).
 
 ## Creating Prowjobs
-`sandboxed-containers-operator-create-prowjob-commands.sh update_templates` regenerates all exising prowjobs with the script defaults,  These jobs are used directly by Konflux.  It is preferred to make all changes in the script and not make changes in existing prowjobs.  Also see [Update Templates](#update-templates)
+`sandboxed-containers-operator-create-prowjob-commands.sh update_templates` regenerates all exising prowjobs with the script defaults, these jobs are used directly by Konflux.  It is preferred to make all changes in the script and not make changes in existing prowjobs.  Also see [Update Templates](#update-templates)
 
 `sandboxed-containers-operator-create-prowjob-commands.sh create` creates a yaml file in the current directory. Environment variables alter the yaml output. `create` is used by `update_templates` also.
 
@@ -32,6 +32,8 @@ sandboxed-containers-operator-create-prowjob-commands.sh run <YAMLFILE> <PROVIDE
    ```bash
    sed -ie 's/restrict_network_access: false/restrict_network_access: true/ ' YAMLFILE
    ```
+**NOTE: this will prevent the RPM upload if you need to install one!**  You will need to upload the RPM to the nodes and install them after the kataconfig is installed.  It will also make the automated tests invalid
+
 4. Now follow the directions to mv the file, add to git, run make commands
 5. `git status -uno` and git add any changed files
 6. `git commit -m '[DEBUG] [DO NOT MERGE]'`

ci-operator/step-registry/sandboxed-containers-operator/create-prowjob/sandboxed-containers-operator-create-prowjob-commands.sh

@@ -194,8 +194,7 @@ validate_and_set_defaults() {
     fi
 }
 
-# Function to show usage
-# Continuation indent = length(MUST_GATHER_ON_FAILURE_ONLY) + 1 = 28 spaces
+
 show_usage() {
     echo "Usage: $0 <command>"
     echo ""
@@ -490,17 +489,22 @@ EOF
     echo "Option B - Submit configuration to CI:"
     echo "1. Review the created configuration file:"
     echo "   cat ${OUTPUT_FILE}"
+    echo "2. Modify the file to allow "
+    echo "   sed -ie 's/restrict_network_access: false/restrict_network_access: true/ ' ${OUTPUT_FILE}"
+    echo "**NOTE: this will prevent the RPM upload if you need to install one!**"
+    echo "You will need to upload the RPM to the nodes and install them after the kataconfig is installed."
+    echo "It will also make the automated tests invalid"
     echo ""
-    echo "2. Move it to the appropriate directory:"
+    echo "3. Move it to the appropriate directory:"
     echo "mv ${OUTPUT_FILE} ci-operator/config/openshift/sandboxed-containers-operator/"
     echo ""
-    echo "3. Add to git:"
+    echo "4. Add to git:"
     echo "git add ci-operator/config/openshift/sandboxed-containers-operator/${OUTPUT_FILE}"
     echo ""
-    echo "4. Generate and update CI configuration before creating PR:"
+    echo "5. Generate and update CI configuration before creating PR:"
     echo "make ci-operator-config && make registry-metadata && make prow-config && make jobs && make update"
     echo ""
-    echo "5. git add changes, commit and push to PR"
+    echo "6. git add changes, commit and push to PR"
     echo ""
 }