Skip to content

Commit b47c4f1

Browse files
committed
Warning that RPM install won't work on interactive PR
Add the sed -ie 's/restrict_network_access: false/restrict_network_access: true/' directions to the script output. This means the RPM upload won't work because the undercluster won't have network access Added a warning to script & docs about this Signed-off-by: Tom Buskey <tbuskey@redhat.com>
1 parent 4afdffc commit b47c4f1

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

ci-operator/step-registry/sandboxed-containers-operator/create-prowjob/sandboxed-containers-operator-create-prowjob-commands.sh

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,7 @@ validate_and_set_defaults() {
194194
fi
195195
}
196196

197-
# Function to show usage
198-
# Continuation indent = length(MUST_GATHER_ON_FAILURE_ONLY) + 1 = 28 spaces
197+
199198
show_usage() {
200199
echo "Usage: $0 <command>"
201200
echo ""
@@ -490,17 +489,22 @@ EOF
490489
echo "Option B - Submit configuration to CI:"
491490
echo "1. Review the created configuration file:"
492491
echo " cat ${OUTPUT_FILE}"
492+
echo "2. Modify the file to allow "
493+
echo " sed -ie 's/restrict_network_access: false/restrict_network_access: true/ ' ${OUTPUT_FILE}"
494+
echo "**NOTE: this will prevent the RPM upload if you need to install one!**"
495+
echo "You will need to upload the RPM to the nodes and install them after the kataconfig is installed."
496+
echo "It will also make the automated tests invalid"
493497
echo ""
494-
echo "2. Move it to the appropriate directory:"
498+
echo "3. Move it to the appropriate directory:"
495499
echo "mv ${OUTPUT_FILE} ci-operator/config/openshift/sandboxed-containers-operator/"
496500
echo ""
497-
echo "3. Add to git:"
501+
echo "4. Add to git:"
498502
echo "git add ci-operator/config/openshift/sandboxed-containers-operator/${OUTPUT_FILE}"
499503
echo ""
500-
echo "4. Generate and update CI configuration before creating PR:"
504+
echo "5. Generate and update CI configuration before creating PR:"
501505
echo "make ci-operator-config && make registry-metadata && make prow-config && make jobs && make update"
502506
echo ""
503-
echo "5. git add changes, commit and push to PR"
507+
echo "6. git add changes, commit and push to PR"
504508
echo ""
505509
}
506510

0 commit comments

Comments
 (0)