Skip to content

Upgrade golangci-lint from v1 to v2.11.4#52

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
sebrandon1:golangci-lint-v2-upgrade
Apr 16, 2026
Merged

Upgrade golangci-lint from v1 to v2.11.4#52
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
sebrandon1:golangci-lint-v2-upgrade

Conversation

@sebrandon1
Copy link
Copy Markdown
Member

@sebrandon1 sebrandon1 commented Jan 16, 2026

Summary

  • Upgrade golangci-lint from v1.61.0 to v2.11.4
  • Update module path to include /v2/ prefix
  • Migrate .golangci.yml to v2 format:
    • Add version: "2" declaration
    • Move formatters (gofmt, goimports) to formatters.enable section
    • Convert issues.exclude-rules to linters.exclusions.rules

Note: This PR may require a corresponding change in the openshift/release repo to update Prow CI configurations, similar to openshift/release#72623

Tracking: redhat-best-practices-for-k8s/telco-bot#49

@karampok
Copy link
Copy Markdown
Contributor

/approve

@sebrandon1 can you please rebase

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karampok, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@sebrandon1 sebrandon1 force-pushed the golangci-lint-v2-upgrade branch from d4ecda7 to 2ceb80b Compare April 15, 2026 14:27
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2026
@sebrandon1 sebrandon1 force-pushed the golangci-lint-v2-upgrade branch from 2ceb80b to a064029 Compare April 15, 2026 14:28
@sebrandon1 sebrandon1 changed the title Upgrade golangci-lint from v1 to v2 Upgrade golangci-lint from v1 to v2.11.4 Apr 15, 2026
@sebrandon1
Copy link
Copy Markdown
Member Author

@karampok Done!

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@karampok
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2026
@karampok
Copy link
Copy Markdown
Contributor

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@karampok: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 38ebf24 into openshift:main Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants