[release-4.21] NO-JIRA: rhaos-pkgs-match-openshift: exclude known package mismatches#1889
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@marmijo: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
I think this one is ready now that the one for master got merged? |
openshift-ci
bot
added
the
backport-risk-assessed
Introduce `RHAOS_PACKAGE_EXCEPTIONS` and build a regex from it to filter out packages that are known to not match the target version of openshift. Use a list-based structure so additional packages can be excluded in the future by appending to the exception array. Exclude the toolbox rhaos package, which is known to not match the target version of openshift. Also exclude the conmon-rs package and remove the rhaos-pkgs-match-openshift test from the denylist. See: openshift#1847 This backports openshift@ef8a3bb and part of openshift@3f11128
The build-node-image job only tests tags with the openshift tag and any tests still in this repo should be running so let's add the openshift tag to them.
marmijo
force-pushed
the
rhaos-pkgs-exception
branch
from
9faa3a3 to
e21822e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@marmijo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, marmijo, prestist, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @marmijo |
openshift-ci-robot
added
the
verified
|
@dustymabe: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dustymabe
added
the
jira/valid-bug
openshift-merge-bot
bot
merged commit d36a4d9
into
openshift:release-4.21
5 participants
Introduce
RHAOS_PACKAGE_EXCEPTIONSand build a regex from it to filter out packages that are known to not match the target version of openshift. Use a list-based structure so additional packages can be excluded in the future by appending to the exception array.Exclude the toolbox and conmon rhaos packages, which are not expected to match.
Also remove the
rhaos-pkgs-match-openshifttest from the denylist.See: #1847
This also backports 1abf0f6