OCPBUGS-92831: Add missing IAM permissions to HCP AWS STS role policy

[asadawar]

Summary

• Add 5 missing IAM permissions to the documented HCP AWS STS CLI role policy in hcp-aws-create-role-sts-creds.adoc
• Aligns the documented policy with the hypershift source of truth (cmd/infra/aws/create_cli_role.go)

Why this change

The documented IAM policy for creating an AWS STS role for HCP is missing permissions that the hcp CLI expects. A customer following the documented procedure was able to create a cluster, but hcp destroy cluster aws failed with AccessDenied errors during IAM cleanup:

failed to list attached policies for role: iam:ListAttachedRolePolicies ... AccessDenied
failed to list inline policies for role: iam:ListRolePolicies ... AccessDenied

Comparing the documented policy against the hypershift source (cmd/infra/aws/create_cli_role.go), the following 5 permissions are in the source but missing from the docs:

Permission	Purpose
iam:ListAttachedRolePolicies	Destroy: list managed policies before role deletion
iam:ListRolePolicies	Destroy: list inline policies before role deletion
iam:DetachRolePolicy	Destroy: detach managed policies before role deletion
iam:TagInstanceProfile	Create: tag instance profiles
iam:TagOpenIDConnectProvider	Create: tag OIDC providers

The new permissions are inserted in the same position as they appear in the hypershift source to keep the policy consistent.

OCPBUGS-92831: https://redhat.atlassian.net/browse/OCPBUGS-92831

[openshift-ci-robot]

@asadawar: This pull request references Jira Issue OCPBUGS-92831, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Add 5 missing IAM permissions to the documented HCP AWS STS CLI role policy in hcp-aws-create-role-sts-creds.adoc
• Aligns the documented policy with the hypershift source of truth (cmd/infra/aws/create_cli_role.go)

Why this change

The documented IAM policy for creating an AWS STS role for HCP is missing permissions that the hcp CLI expects. A customer following the documented procedure was able to create a cluster, but hcp destroy cluster aws failed with AccessDenied errors during IAM cleanup:

failed to list attached policies for role: iam:ListAttachedRolePolicies ... AccessDenied
failed to list inline policies for role: iam:ListRolePolicies ... AccessDenied

Comparing the documented policy against the hypershift source (cmd/infra/aws/create_cli_role.go), the following 5 permissions are in the source but missing from the docs:

Permission	Purpose
iam:ListAttachedRolePolicies	Destroy: list managed policies before role deletion
iam:ListRolePolicies	Destroy: list inline policies before role deletion
iam:DetachRolePolicy	Destroy: detach managed policies before role deletion
iam:TagInstanceProfile	Create: tag instance profiles
iam:TagOpenIDConnectProvider	Create: tag OIDC providers

The new permissions are inserted in the same position as they appear in the hypershift source to keep the policy consistent.

OCPBUGS-92831: https://redhat.atlassian.net/browse/OCPBUGS-92831

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[asadawar]

/label merge-review-needed

[asadawar]

/jira refresh

[openshift-ci-robot]

@asadawar: This pull request references Jira Issue OCPBUGS-92831, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[asadawar]

/jira refresh

[openshift-ci-robot]

@asadawar: This pull request references Jira Issue OCPBUGS-92831, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Thu Jul 09 17:22:20 - Prow CI generated the docs preview:

https://115006--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-aws.html

[openshift-ci]

@asadawar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.