OCPBUGS-87223: Add token-based auth prerequisite for oc adm upgrade recommend

[asadawar]

Summary

• Adds a prerequisite to the oc adm upgrade recommend documentation noting that token-based authentication (e.g., oc login -u kubeadmin) is required
• Documents that certificate-based auth (system:admin from the installer kubeconfig) causes the command to silently skip all alert-based precondition checks
• Includes the exact error message users see so it is searchable

Context

Found during OCP 4.22 pre-GA hackathon testing of OCPSTRAT-2781. The Thanos monitoring route uses kube-rbac-proxy with TokenReview-based auth only (no --client-ca-file on port 9091), so certificate-based authentication is structurally impossible (source).

Root cause discussed with OTA maintainer (W Trevor King): The real fix belongs to the monitoring team — either providing a dedicated Thanos-access SA or adding --client-ca-file to kube-rbac-proxy-web. OTA should not hardcode SA assumptions. This doc PR is a band-aid documenting the current token requirement.

• Monitoring docs reference: Accessing monitoring APIs by using the CLI

Test plan

• Verified on OCP 4.22.0-rc.4 that system:admin produces Failed to check for at least some preconditions: no token is currently in use for this session
• Verified that oc login -u kubeadmin resolves the issue and all precheck categories are displayed
• Verified API server proxy to thanos-querier returns 401 (kube-rbac-proxy-web has no --client-ca-file)
• Verified oc create token <SA> works from cert auth but choosing the right SA is a monitoring team decision

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87223

[openshift-ci]

Hi @asadawar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[asadawar]

/ok-to-test

[ocpdocs-previewbot]

🤖 Thu Jul 09 16:59:57 - Prow CI generated the docs preview:

https://112077--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/preparing_for_updates/updating-cluster-prepare.html

[asadawar]

/jira refresh

[openshift-ci-robot]

@asadawar: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[asadawar]

/jira refresh

[openshift-ci-robot]

@asadawar: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[asadawar]

/jira refresh

[openshift-ci-robot]

@asadawar: This pull request references OSDOCS-19867 which is a valid jira issue.

Details

In response to this:

Summary

• Adds a prerequisite to the oc adm upgrade recommend documentation noting that token-based authentication (e.g., oc login -u kubeadmin) is required
• Documents that certificate-based auth (system:admin from the installer kubeconfig) causes the command to silently skip all alert-based precondition checks
• Includes the exact error message users see so it is searchable

Context

Found during OCP 4.22 pre-GA hackathon testing of OCPSTRAT-2781. The Thanos monitoring route uses kube-rbac-proxy with TokenReview-based auth only (no --client-ca-file on port 9091), so certificate-based authentication is structurally impossible (source).

Root cause discussed with OTA maintainer (W Trevor King): The real fix belongs to the monitoring team — either providing a dedicated Thanos-access SA or adding --client-ca-file to kube-rbac-proxy-web. OTA should not hardcode SA assumptions. This doc PR is a band-aid documenting the current token requirement.

• Monitoring docs reference: Accessing monitoring APIs by using the CLI

Test plan

• Verified on OCP 4.22.0-rc.4 that system:admin produces Failed to check for at least some preconditions: no token is currently in use for this session
• Verified that oc login -u kubeadmin resolves the issue and all precheck categories are displayed
• Verified API server proxy to thanos-querier returns 401 (kube-rbac-proxy-web has no --client-ca-file)
• Verified oc create token <SA> works from cert auth but choosing the right SA is a monitoring team decision

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87223

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@asadawar: This pull request references OSDOCS-19867 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[asadawar]

/jira refresh

[openshift-ci-robot]

@asadawar: This pull request references Jira Issue OCPBUGS-87223, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@asadawar: This pull request references Jira Issue OCPBUGS-87223, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Adds a prerequisite to the oc adm upgrade recommend documentation noting that token-based authentication (e.g., oc login -u kubeadmin) is required
• Documents that certificate-based auth (system:admin from the installer kubeconfig) causes the command to silently skip all alert-based precondition checks
• Includes the exact error message users see so it is searchable

Context

Found during OCP 4.22 pre-GA hackathon testing of OCPSTRAT-2781. The Thanos monitoring route uses kube-rbac-proxy with TokenReview-based auth only (no --client-ca-file on port 9091), so certificate-based authentication is structurally impossible (source).

Root cause discussed with OTA maintainer (W Trevor King): The real fix belongs to the monitoring team — either providing a dedicated Thanos-access SA or adding --client-ca-file to kube-rbac-proxy-web. OTA should not hardcode SA assumptions. This doc PR is a band-aid documenting the current token requirement.

• Monitoring docs reference: Accessing monitoring APIs by using the CLI

Test plan

• Verified on OCP 4.22.0-rc.4 that system:admin produces Failed to check for at least some preconditions: no token is currently in use for this session
• Verified that oc login -u kubeadmin resolves the issue and all precheck categories are displayed
• Verified API server proxy to thanos-querier returns 401 (kube-rbac-proxy-web has no --client-ca-file)
• Verified oc create token <SA> works from cert auth but choosing the right SA is a monitoring team decision

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87223

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[asadawar]

/label merge-review-needed

[dis016]

/lgtm

[skopacz1]

Just one small formatting thing, then this PR is good to go! Thanks for submitting this

[skopacz1]

Could you change this to a code block instead? It would look like this:

Suggested change

	`Failed to check for at least some preconditions: no token is currently in use for this session`
	[source,terminal]
	----
	Failed to check for at least some preconditions: no token is currently in use for this session
	----

[asadawar]

sure. Thanks for the review. Applying the suggested changes.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@asadawar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[skopacz1]

LGTM

[openshift-ci-robot]

@asadawar: Jira Issue OCPBUGS-87223: All pull requests linked via external trackers have merged:

• openshift/openshift-docs#112077

Jira Issue OCPBUGS-87223 has been moved to the MODIFIED state.

Details

In response to this:

Summary

• Adds a prerequisite to the oc adm upgrade recommend documentation noting that token-based authentication (e.g., oc login -u kubeadmin) is required
• Documents that certificate-based auth (system:admin from the installer kubeconfig) causes the command to silently skip all alert-based precondition checks
• Includes the exact error message users see so it is searchable

Context

Found during OCP 4.22 pre-GA hackathon testing of OCPSTRAT-2781. The Thanos monitoring route uses kube-rbac-proxy with TokenReview-based auth only (no --client-ca-file on port 9091), so certificate-based authentication is structurally impossible (source).

Root cause discussed with OTA maintainer (W Trevor King): The real fix belongs to the monitoring team — either providing a dedicated Thanos-access SA or adding --client-ca-file to kube-rbac-proxy-web. OTA should not hardcode SA assumptions. This doc PR is a band-aid documenting the current token requirement.

• Monitoring docs reference: Accessing monitoring APIs by using the CLI

Test plan

• Verified on OCP 4.22.0-rc.4 that system:admin produces Failed to check for at least some preconditions: no token is currently in use for this session
• Verified that oc login -u kubeadmin resolves the issue and all precheck categories are displayed
• Verified API server proxy to thanos-querier returns 401 (kube-rbac-proxy-web has no --client-ca-file)
• Verified oc create token <SA> works from cert auth but choosing the right SA is a monitoring team decision

Fixes: https://redhat.atlassian.net/browse/OCPBUGS-87223

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[skopacz1]

/cherrypick enterprise-4.22
/cherrypick enterprise-5.0

[openshift-cherrypick-robot]

@skopacz1: new pull request created: #115031

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@skopacz1: new pull request created: #115032

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.