OCPBUGS-76482: CVE-2025-65637 - Bump github.com/sirupsen/logrus from v1.9.0 to v1.9.3 [release-4.13]

[rissh]

Bump github.com/sirupsen/logrus to v1.9.3 to fix GHSA-4f99-4q7p-p3gh (DoS in logrus). Direct dependency update only; library-go is unchanged to avoid k8s version drift (per approach on #609).

Changes
Bumped github.com/sirupsen/logrus from v1.9.0 to v1.9.3
CVE
GHSA-4f99-4q7p-p3gh | High (CVSS 7.5) | Fixed in v1.9.3

[openshift-ci-robot]

@rissh: This pull request references Jira Issue OCPBUGS-76482, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-76483 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump github.com/sirupsen/logrus to v1.9.3 to fix GHSA-4f99-4q7p-p3gh (DoS in logrus). Direct dependency update only; library-go is unchanged to avoid k8s version drift (per approach on #609).

Changes
Bumped github.com/sirupsen/logrus from v1.9.0 to v1.9.3
CVE
GHSA-4f99-4q7p-p3gh | High (CVSS 7.5) | Fixed in v1.9.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8e05173-97d3-4538-889a-0c07fe317154

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rissh]

/retest

[rissh]

/retest

[rissh]

/retest

[rissh]

/jira refresh

[openshift-ci-robot]

@rissh: This pull request references Jira Issue OCPBUGS-76482, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rissh]

Failure 1: ci/prow/unit -- TestImageStreamImportQuayIO

Test: pkg/image/apiserver/importer.TestImageStreamImportQuayIO
Duration: 320ms (all runs)
Failed: 4/4 runs (100% consistent)

Root cause: Pre-existing test issue, not related to logrus bump.

This test is in import_integration_test.go and makes a live HTTP call to quay.io/coreos/etcd to test image stream importing. It's been in the codebase since well before this PR. The logrus bump doesn't touch any import/image code.

The quay.io/coreos/etcd image still exists (I verified it returns HTTP 200), but it uses the deprecated Docker Image Format v1 / manifest schema 1. This has been flagged as a known issue (etcd-io/etcd#17812). The test completing in only 320ms (without hitting the retry backoff that starts at 500ms+) indicates the failure error message doesn't match the retry patterns -- the test gets a non-retriable error, likely related to the deprecated manifest format or a changed API response.

Key point: This test would fail on the bare release-4.13 branch even without the PR. It's not caused by the logrus bump at all.

Failure 2: ci/prow/e2e-aws-ovn-serial -- Pod Disks test

Test: [sig-storage] Pod Disks [Feature:StorageProvider] [Serial] attach on previously attached volumes should work

Root cause: CI infrastructure issue -- same class as PR #610.

The actual failure from the log:

fail [k8s.io/kubernetes@v1.26.1/test/e2e/storage/pd.go:475]:
Error attaching PD: error attaching volume vol-0010f6209627c2e32 to node ip-10-0-173-209.ec2.internal:
error finding node ip-10-0-173-209.ec2.internal:
error listing AWS instances: MissingRegion: could not find region configuration

This is the pd.go test (Persistent Disk) which is GCE-specific code trying to run on AWS. The MissingRegion error confirms it's trying to use GCE PD logic on an AWS node. This is the exact same CI infra issue analyzed by wangke19 on PR #610 -- the CI failed to extract the correct k8s-tests binary (which would have this test annotated as [Disabled:Broken]), and fell back to an older binary that doesn't skip it.

All the other "Ginkgo exit error 3" entries in the log are just test skips (GCE-only tests on AWS, local driver not supporting DynamicPV, etc.) -- those are expected and harmless.

[rissh]

Could we /override unit and /override e2e-aws-ovn-serial so this CVE fix can proceed?
I also re-running the failed test again.

@benluddy @sanchezl ^^

[rissh]

/retest

[rissh]

/jira refresh

[openshift-ci-robot]

@rissh: This pull request references Jira Issue OCPBUGS-76482, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-76483 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-76483 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jubittajohn]

/test unit

[jubittajohn]

/lgtm
The job failures on this PR are unrelated to the changes and are due to the reasons explained in this comment: #613 (comment)

[jubittajohn]

/test e2e-aws-ovn-serial

[sanchezl]

Logrus CVE bump, changes lgtm. Overriding known failures:

• unit: quay.io/coreos/etcd:latest removed (fix in OCPBUGS-78596: Fix image reference in TestImageStreamImportQuayIO [release-4.13]  #622)
• e2e-aws-ovn-serial: known flake, same override agreed on CKAO#2048

/approve
/override ci/prow/unit
/override ci/prow/e2e-aws-ovn-serial
/verified bypass

[openshift-ci-robot]

@sanchezl: The verified label has been added.

Details

In response to this:

Logrus CVE bump, changes lgtm. Overriding known failures:

• unit: quay.io/coreos/etcd:latest removed (fix in OCPBUGS-78596: Fix image reference in TestImageStreamImportQuayIO [release-4.13]  #622)
• e2e-aws-ovn-serial: known flake, same override agreed on CKAO#2048

/approve
/override ci/prow/unit
/override ci/prow/e2e-aws-ovn-serial
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jubittajohn, rissh, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sanchezl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sanchezl: Overrode contexts on behalf of sanchezl: ci/prow/e2e-aws-ovn-serial, ci/prow/unit

Details

In response to this:

Logrus CVE bump, changes lgtm. Overriding known failures:

• unit: quay.io/coreos/etcd:latest removed (fix in OCPBUGS-78596: Fix image reference in TestImageStreamImportQuayIO [release-4.13]  #622)
• e2e-aws-ovn-serial: known flake, same override agreed on CKAO#2048

/approve
/override ci/prow/unit
/override ci/prow/e2e-aws-ovn-serial
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@rissh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-serial	47479be	link	true	/test e2e-aws-ovn-serial
ci/prow/unit	47479be	link	true	/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sanchezl]

/label backport-risk-assessed

[openshift-ci]

@sanchezl: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rissh]

/label backport-risk-assessed

Hey @sanchezl ,
Do you know someone with the access for this label? OR if you wanted I can pull someone to add it for us if we wanted to.

[shannon]

/label backport-risk-assessed

[openshift-ci-robot]

@rissh: An error was encountered invalid pull identifier with 2 parts: "mjuanxd/logrus-dos-poc" for bug OCPBUGS-76482 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message.

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.Jira Issue Verification Checks: Jira Issue OCPBUGS-76482
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-76482 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Bump github.com/sirupsen/logrus to v1.9.3 to fix GHSA-4f99-4q7p-p3gh (DoS in logrus). Direct dependency update only; library-go is unchanged to avoid k8s version drift (per approach on #609).

Changes
Bumped github.com/sirupsen/logrus from v1.9.0 to v1.9.3
CVE
GHSA-4f99-4q7p-p3gh | High (CVSS 7.5) | Fixed in v1.9.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.