NO-JIRA: Fix iterating over stream.Status.Tags

[vincentdephily]

Iteration is over an []T, not a map[string]T, tag string is in T.Tag.

Only affects log output. Mistake was AFAICT here from the start, but only showed up a typecheck error with go 1.26.

Summary by CodeRabbit

• Bug Fixes
  • Improved image stream graph handling so image tag history is processed more reliably.
  • Logging now reports the correct tag and image reference when an image cannot be found, making issues easier to diagnose.

[openshift-ci-robot]

@vincentdephily: This pull request explicitly references no jira issue.

Details

In response to this:

Iteration is over an []T, not a map[string]T, tag string is in T.Tag.

Only affects log output. Mistake was AFAICT here from the start, but only showed up a typecheck error with go 1.26.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The addImageStreamsToGraph function in pkg/cli/admin/top/graph.go was updated to iterate tag histories directly rather than via key-value pairs, and to use ranged index/item variables in the inner loop, adjusting the missing-image log message accordingly.

Changes

Tag History Iteration Update

Layer / File(s)	Summary
Loop variable and log message update pkg/cli/admin/top/graph.go	Outer loop now ranges over histories directly instead of (tag, history) pairs; inner loop ranges over history.Items as (i, image) instead of indexing; the "Unable to find image" log now uses history.Tag and the ranged item's DockerImageReference.

Estimated code review effort: 1 (Trivial) | ~3 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@vincentdephily: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tchap]

/lgtm

We will need to verify this manually, I guess.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap, vincentdephily
Once this PR has been reviewed and has the lgtm label, please assign ardaguclu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment