Skip to content

Remove docker/docker as a dependency#2298

Open
rh-roman wants to merge 4 commits into
openshift:mainfrom
rh-roman:drop-docker-exp
Open

Remove docker/docker as a dependency#2298
rh-roman wants to merge 4 commits into
openshift:mainfrom
rh-roman:drop-docker-exp

Conversation

@rh-roman

@rh-roman rh-roman commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Per moby/moby#52404

Starting with Docker v29, the Go module github.com/docker/docker is deprecated and will no longer be updated.

Although oc doesn't use a lot of functionality from docker/docker, it will get flagged any time CVEs are found in docker (like https://www.cve.org/CVERecord?id=CVE-2026-42306).

Updating oc to not depend on docker/docker.

Summary by CodeRabbit

  • Bug Fixes
    • Improved image archive extraction and layer unpacking across platforms, including more reliable handling of decompression and tar buffering.
    • Corrected file metadata application during extraction (timestamps, ownership/ID remapping, and extended attributes/whiteout behavior), with graceful handling when xattr support isn’t available.
  • Compatibility
    • Updated Docker credential handling to support the newer authentication config format used by the credential store.

moby/go-archive is the standalone archive module extracted from docker/docker; use it
directly rather than going through docker/docker's re-export shim.
@openshift-ci openshift-ci Bot requested review from atiratree and ingvagabund July 6, 2026 13:09
@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-roman
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Walkthrough

This PR updates archive extraction to use moby archive and user mapping packages with local xattr and timestamp helpers, switches release and image extraction decompression call sites, and migrates docker credential handling to Podman auth config types.

Changes

Archive extraction and platform helper migration

Layer / File(s) Summary
Dependency and archive API updates
go.mod, pkg/cli/admin/release/new.go, pkg/cli/image/extract/extract.go
Removes github.com/docker/docker, updates go-dockerclient, and switches decompression call sites to github.com/moby/go-archive/compression.
Tar unpacking and identity mapping
pkg/cli/image/archive/archive.go
Adds a local Identity type, changes TarOptions.ChownOpts, remaps IDs with moby/sys/user, and updates tar unpacking to use the local buffer pool and os.MkdirAll.
Filesystem metadata application
pkg/cli/image/archive/archive.go
Applies directory times, chown options, xattrs, and file timestamps through local helpers, including timestamp clamping before os.Chtimes.
Platform helper implementations
pkg/cli/image/archive/archive_linux.go, pkg/cli/image/archive/archive_other.go
Defines Linux syscall-based xattr and timestamp helpers, non-Linux stubs, and the whiteout xattr lookup change.
Docker auth config migration
pkg/cli/image/manifest/dockercredentials/credential_store_factory.go
Replaces Docker registry auth config with containertypes.DockerAuthConfig in construction, exported signatures, and stored state.

Estimated code review effort: 4 (Complex) | ~55 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseCommand
  participant ExtractCommand
  participant ArchivePackage
  participant Filesystem
  participant CredentialsFactory

  ReleaseCommand->>ArchivePackage: DecompressStream(r)
  ExtractCommand->>ArchivePackage: DecompressStream
  ArchivePackage->>Filesystem: os.MkdirAll / lsetxattr / chtimes / lutimesNano
  CredentialsFactory->>CredentialsFactory: build DockerAuthConfig
Loading
🚥 Pre-merge checks | ✅ 5 | ❌ 10

❌ Failed checks (10 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs ❓ Inconclusive Repository clone failed, so this custom check could not run with code access. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing github.com/docker/docker as a dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

rh-roman added 3 commits July 6, 2026 09:52
pkg/pools, pkg/system, and pkg/idtools have no stable API outside docker/docker.
Replace with stdlib (bufio sync.Pool, os.MkdirAll/Chtimes), direct unix syscalls
(lgetxattr/lsetxattr/UtimesNanoAt), and moby/sys/user for identity mapping.
Replace api/types/registry.AuthConfig with the podman-equivalent DockerAuthConfig
already used elsewhere in this package.
v1.13.2 drops docker/docker in favour of moby/moby, removing the last transitive
dependency on github.com/docker/docker.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
pkg/cli/image/manifest/dockercredentials/credential_store_factory.go (1)

37-46: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Simplify the credential copy. findAuthentication returns containertypes.DockerAuthConfig, so this field-by-field literal is redundant; pass &authCfg directly to NewDynamicCredentialStore instead.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/cli/image/manifest/dockercredentials/credential_store_factory.go` around
lines 37 - 46, The credential creation in CredentialStoreFactory is doing a
redundant field-by-field copy after findAuthentication already returns a
containertypes.DockerAuthConfig. Update the return in CredentialStoreFactory to
pass the authCfg value directly into NewDynamicCredentialStore, keeping the
existing error handling and the nocreds fallback unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/cli/image/archive/archive.go`:
- Around line 81-89: The RemapIDs type currently cannot be safely created
outside its package because mappings is unexported, and Alter will panic if
mappings is nil. Add a constructor or exported setter for RemapIDs so callers
can provide the moby_user.IdentityMapping, and update Alter to guard against a
nil mappings value before calling ToHost. Use the RemapIDs and Alter symbols to
locate and fix the construction and nil-handling path.

---

Nitpick comments:
In `@pkg/cli/image/manifest/dockercredentials/credential_store_factory.go`:
- Around line 37-46: The credential creation in CredentialStoreFactory is doing
a redundant field-by-field copy after findAuthentication already returns a
containertypes.DockerAuthConfig. Update the return in CredentialStoreFactory to
pass the authCfg value directly into NewDynamicCredentialStore, keeping the
existing error handling and the nocreds fallback unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 753fb51d-28d5-48e2-8898-8789271e9a99

📥 Commits

Reviewing files that changed from the base of the PR and between a7ad572 and 08fa3b8.

⛔ Files ignored due to path filters (139)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/docker/docker/AUTHORS is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/NOTICE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/blkiodev/blkio.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/common/id_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/change_type.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/change_types.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/commit.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/container.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/create_request.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/create_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/disk_usage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/errors.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/exec.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/filesystem_change.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/health.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/hostconfig.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/hostconfig_unix.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/hostconfig_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/network_settings.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/options.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/port.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/state.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/stats.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/top_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/update_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/wait_exit_error.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/wait_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/container/waitcondition.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/filters/errors.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/filters/filters_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/filters/parse.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/mount/mount.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/network/create_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/network/endpoint.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/network/ipam.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/network/network.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/registry/authconfig.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/registry/authenticate.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/registry/registry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/storage/driver_data.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/strslice/strslice.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/common.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/config.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/container.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/network.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/runtime.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/runtime/runtime.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/secret.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/service.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/service_create_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/service_update_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/swarm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/swarm/task.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/api/types/versions/compare.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/archive_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/changes_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/copy_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/diff_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/path_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/utils.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/whiteouts_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/archive/wrap_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/homedir/homedir.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/homedir/homedir_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/homedir/homedir_others.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/idtools/idtools.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/idtools/idtools_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/ioutils/fswriters_deprecated.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/ioutils/readers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/ioutils/writeflusher.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/ioutils/writers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/jsonmessage/jsonmessage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/pools/pools.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/args_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/chtimes.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/chtimes_nowindows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/chtimes_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/errors.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/filesys.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/filesys_unix.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/filesys_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/init_windows.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/utimes_unix.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/utimes_unsupported.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/xattrs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/xattrs_linux.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/docker/pkg/system/xattrs_unsupported.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/go-connections/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/go-connections/nat/nat.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/go-connections/nat/parse.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/docker/go-connections/nat/sort.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/.golangci.yaml is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/client.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/container.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/container_stats.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/container_update.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/distribution.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/event.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/exec.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/image.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/misc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/network.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/plugin.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/swarm.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/swarm_configs.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/swarm_node.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/swarm_secrets.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/swarm_service.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/swarm_task.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/tar.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/fsouza/go-dockerclient/volume.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/docker-image-spec/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/docker-image-spec/specs-go/v1/image.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/go-archive/archive.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/go-archive/xattr_supported_unix.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/pkg/stdcopy/stdcopy.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/jsonstream/json_error.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/jsonstream/message.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/jsonstream/progress.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/registry/auth_response.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/registry/authconfig.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/registry/registry.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/api/types/registry/search.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/moby/client/pkg/jsonmessage/jsonmessage.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/patternmatcher/patternmatcher.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/moby/sys/atomicwriter/atomicwriter.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/README.md is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/aec.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/ansi.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/builder.go is excluded by !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/sample.gif is excluded by !**/*.gif, !vendor/**, !**/vendor/**
  • vendor/github.com/morikuni/aec/sgr.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (7)
  • go.mod
  • pkg/cli/admin/release/new.go
  • pkg/cli/image/archive/archive.go
  • pkg/cli/image/archive/archive_linux.go
  • pkg/cli/image/archive/archive_other.go
  • pkg/cli/image/extract/extract.go
  • pkg/cli/image/manifest/dockercredentials/credential_store_factory.go

Comment thread pkg/cli/image/archive/archive.go
@rh-roman

rh-roman commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@rh-roman

rh-roman commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2026
"github.com/docker/docker/pkg/system"
"github.com/moby/go-archive/compression"
"github.com/moby/sys/sequential"
moby_user "github.com/moby/sys/user"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I would prefer to have this labeled as mobyuser. I don't think underscores are very often used.

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@rh-roman: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants