Skip to content

[release-4.15] NO-JIRA: fix vendor for hermetic 4.15#1361

Open
fgallott wants to merge 1 commit intoopenshift:release-4.15from
fgallott:hermetic-4.15
Open

[release-4.15] NO-JIRA: fix vendor for hermetic 4.15#1361
fgallott wants to merge 1 commit intoopenshift:release-4.15from
fgallott:hermetic-4.15

Conversation

@fgallott
Copy link

@fgallott fgallott commented Feb 27, 2026

This is needed for the hermetic migration in konflux, to fix the following error:

Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
  Please try running `go mod vendor` and committing the changes.
  Note that you may need to `git add --force` ignored files in the vendor/ dir.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2026
@openshift-ci-robot
Copy link

@fgallott: This pull request explicitly references no jira issue.

Details

In response to this:

This is needed for the hermetic migration in konflux, to fix the following error:

Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
 Please try running `go mod vendor` and committing the changes.
 Note that you may need to `git add --force` ignored files in the vendor/ dir.

The changes are obtained running go mod tidy and go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from aguidirh and sherine-k February 27, 2026 13:37
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

@fgallott: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@aguidirh aguidirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 2, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adolfo-ab, aguidirh, fgallott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2026
@aguidirh
Copy link
Contributor

aguidirh commented Mar 2, 2026

/verified bypass

Since it is only infra change, QE tests are not needed here.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 2, 2026
@openshift-ci-robot
Copy link

@aguidirh: The verified label has been added.

Details

In response to this:

/verified bypass

Since it is only infra change, QE tests are not needed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aguidirh aguidirh changed the title [release-4.15] NO-JIRA: fix vendor for hermetic 4.15 NO-JIRA: [release-4.15] fix vendor for hermetic 4.15 Mar 2, 2026
@aguidirh aguidirh changed the title NO-JIRA: [release-4.15] fix vendor for hermetic 4.15 [release-4.15] NO-JIRA: fix vendor for hermetic 4.15 Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants