CLID-535: api: use OCI definitions from opencontainers spec#1341
CLID-535: api: use OCI definitions from opencontainers spec#1341r4f4 wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
approved
r4f4
force-pushed
the
use-opencontainer-types
branch
2 times, most recently
from
fca8c04 to
0fe3536
Compare
internal/pkg/operator/common.go
Outdated
| // "configs" will be exactly the same | ||
| if len(oci.Manifests) > 0 && oci.Config.Size == 0 { | ||
| subDigest, err := digest.Parse(oci.Manifests[0].Digest) | ||
| if ociManifest.Config.Size == 0 { |
There was a problem hiding this comment.
Is there a better way to determine if it's an index or a manifest?
There was a problem hiding this comment.
There is a more manual way: load the json as a map and check if MediaType is set.
Instead of implementing our own types.
r4f4
force-pushed
the
use-opencontainer-types
branch
from
0fe3536 to
ee3df91
Compare
|
@r4f4: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/retitle CLID-535: api: use OCI definitions from opencontainers spec |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@r4f4: This pull request references CLID-535 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@aguidirh: This pull request references CLID-535 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aguidirh
left a comment
aguidirh
left a comment
There was a problem hiding this comment.
/label acknowledge-critical-fixes-only
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aguidirh, r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Description
Instead of implementing our own types.
Github / Jira issue:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Expected Outcome
Please describe the outcome expected from the tests.