Skip to content

OCPBUGS-65718: multi-arch tests were not passing on ppc64le#1325

Draft
prb112 wants to merge 3 commits intoopenshift:mainfrom
prb112:fix-multi-arch-test
Draft

OCPBUGS-65718: multi-arch tests were not passing on ppc64le#1325
prb112 wants to merge 3 commits intoopenshift:mainfrom
prb112:fix-multi-arch-test

Conversation

@prb112
Copy link
Contributor

@prb112 prb112 commented Dec 6, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Github / Jira issue:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

prb112 added 2 commits December 5, 2025 20:21
@prb112
fix: multi-arch
6756e1d 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
fix: release_isc reset, archive refactored
4b14bd5 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prb112
Once this PR has been reviewed and has the lgtm label, please assign aguidirh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prb112
fix: remove signatures as they aren't generated in the code
b725b96 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 force-pushed the fix-multi-arch-test branch from 8063ab0 to b725b96 Compare December 6, 2025 01:48
prb112
prb112 commented Dec 6, 2025
View reviewed changes
internal/testutils/testutils.go
Comment on lines +137 to +139
cfg.OS = runtime.GOOS
cfg.Architecture = runtime.GOARCH
i, err = mutate.ConfigFile(i, cfg)
Copy link
Contributor Author

@prb112 prb112 Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not get this to work on linux/ppc64le without adding the mutate.ConfigFile with the arch/OS

prb112
prb112 commented Dec 6, 2025
View reviewed changes
Makefile
Comment on lines +55 to +56
$(GO) test $(GO_MOD_FLAGS) $(GO_BUILD_FLAGS) -coverprofile=tests/results-integration/cover-additional.out -race -count=1 ./internal/pkg/... -run 'TestIntegrationAdditional$'
$(GO) test $(GO_MOD_FLAGS) $(GO_BUILD_FLAGS) -coverprofile=tests/results-integration/cover-release.out -race -count=1 ./internal/pkg/... -run 'TestIntegrationRelease$'
Copy link
Contributor Author

@prb112 prb112 Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two ran the M2M tests as well

prb112
prb112 commented Dec 6, 2025
View reviewed changes
internal/pkg/cli/release_integration_test.go
assert.NoError(t, err, "should not fail creating a temp folder for results")

ocmirror.SetArgs([]string{"-c", suite.tempFolder + "/isc.yaml", "--v2", "-p", "56001", "--src-tls-verify=false", "--dest-tls-verify=false", "file://" + resultFolder})
ocmirror.SetArgs([]string{"-c", suite.tempFolder + "/isc.yaml", "--v2", "-p", "56001", "--src-tls-verify=false", "--dest-tls-verify=false", "--remove-signatures", "file://" + resultFolder})
Copy link
Contributor Author

@prb112 prb112 Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add, otherwise fails on pulling the sig

@prb112
Copy link
Contributor Author

prb112 commented Dec 6, 2025

/retitle OCPBUGS-65718: multi-arch tests were not passing on ppc64le

@openshift-ci openshift-ci bot changed the title WIP: Multi-Arch Tests are not passing OCPBUGS-65718: multi-arch tests were not passing on ppc64le Dec 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2025

@prb112: This pull request references Jira Issue OCPBUGS-65718, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Github / Jira issue:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code Improvements (Refactoring, Performance, CI upgrades, etc)
  • Internal repo assets (diagrams / docs on github repo)
  • This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aguidirh
Copy link
Contributor

aguidirh commented Jan 16, 2026

Hi @prb112,

This is a draft PR so I assume it is not ready for code review.

If this is ready for code review, could you please convert it for a non-draft PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prb112 @openshift-ci-robot @aguidirh