refactor: Move Go code to dedicated backend/ directory#755
refactor: Move Go code to dedicated backend/ directory#755machadovilaca wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: machadovilaca The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
|
The proposed structure is aligned with what I described on the call. There seems to be some issue with the PR tests now, I will retrigger them later if needed, their pass is neccessary to ensure that the change is reflected in our automation. |
|
/test all |
|
Not sure if we need this. Even if the backed is on the root, it has its own folders which will include testing and e2e. e2e test for the frontend are already contained inside the |
|
@machadovilaca: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@DavidRajnoha Given Gabriel comment, should we keep the current structure, in the alertmanagement work we are planning to add internal/ and test/e2e/ packages, would you be okay with that? |
No description provided.