Add base alert management API by machadovilaca · Pull Request #657 · openshift/monitoring-plugin

machadovilaca · 2025-11-25T16:49:51Z

No description provided.

openshift-ci · 2025-11-25T16:50:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: machadovilaca
Once this PR has been reviewed and has the lgtm label, please assign peteryurkovich for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

machadovilaca · 2025-11-25T16:51:24Z

/cc @avlitman @sradco

simonpasquier · 2025-11-25T17:18:47Z

/cc @simonpasquier

simonpasquier

Can we have a separate PR on main for the golangci-lint addition? It's very much appreciated but it'd be easier to review separately. Can we also have a minimal golangci-lint configuration? Once this is done we should also consider adding a job to openshift/release to enforce the verification.
Regarding goimports, I'd recommend using the gci linter which does the same IIUC.

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

machadovilaca · 2025-11-26T13:18:37Z

Can we have a separate PR on main for the golangci-lint addition? It's very much appreciated but it'd be easier to review separately. Can we also have a minimal golangci-lint configuration? Once this is done we should also consider adding a job to openshift/release to enforce the verification. Regarding goimports, I'd recommend using the gci linter which does the same IIUC.

removed for now, will create a PR to add it separately

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

jgbernalp · 2025-12-10T12:36:47Z

cmd/plugin-backend.go

 	certArg             = flag.String("cert", "", "cert file path to enable TLS (disabled by default)")
 	keyArg              = flag.String("key", "", "private key file path to enable TLS (disabled by default)")
-	featuresArg         = flag.String("features", "", "enabled features, comma separated.\noptions: ['acm-alerting', 'incidents', 'dev-config', 'perses-dashboards']")
+	featuresArg         = flag.String("features", "", "enabled features, comma separated.\noptions: ['acm-alerting', 'incidents', 'dev-config', 'perses-dashboards', 'management-api']")


Suggested change

featuresArg = flag.String("features", "", "enabled features, comma separated.\noptions: ['acm-alerting', 'incidents', 'dev-config', 'perses-dashboards', 'management-api']")

featuresArg = flag.String("features", "", "enabled features, comma separated.\noptions: ['acm-alerting', 'incidents', 'dev-config', 'perses-dashboards', 'alert-management-api']")

simonpasquier · 2025-12-10T13:54:40Z

pkg/server.go

+
+	if managementClient != nil {
+		managementRouter := managementrouter.New(managementClient)
+		router.PathPrefix("/api/v1/alerting").Handler(managementRouter)


we've discussed before that we wanted an API scheme similar to https://prometheus.io/docs/prometheus/latest/querying/api/#rules so it can be used as a drop-in replacement?

jgbernalp · 2025-12-10T14:01:45Z

internal/managementrouter/alerts_get.go

+	State  string            `form:"state"`
+}
+
+type GetAlertsResponse struct {


this response should match the alerting API response: https://github.com/prometheus/alertmanager/blob/main/api/v2/openapi.yaml#L423

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: João Vilaça <machadovilaca@gmail.com>

Signed-off-by: Shirly Radco <sradco@redhat.com>

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

simonpasquier · 2026-02-05T10:24:11Z

.github/workflows/unit-tests.yaml

you can't have GitHub actions on github.com/openshift

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

coderabbitai · 2026-02-16T09:21:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Signed-off-by: Aviv Litman <alitman@redhat.com>

openshift-ci bot requested review from PeterYurkovich and zhuje November 25, 2025 16:50

openshift-ci bot requested review from avlitman and sradco November 25, 2025 16:51

openshift-ci bot requested a review from simonpasquier November 25, 2025 17:18

simonpasquier reviewed Nov 26, 2025

View reviewed changes

machadovilaca force-pushed the add-alert-management-api-base branch from cfc4748 to dc61cb7 Compare November 26, 2025 13:16

Add base alert management API

5aad6ea

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

machadovilaca force-pushed the add-alert-management-api-base branch from dc61cb7 to 5aad6ea Compare November 26, 2025 13:17

machadovilaca added 2 commits December 9, 2025 16:08

Change IsPlatformAlertRule implementation (#1)

fb8a751

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Set source label to platform on OpenShift alerting rules (#3)

f622f25

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

jgbernalp reviewed Dec 10, 2025

View reviewed changes

simonpasquier reviewed Dec 10, 2025

View reviewed changes

jgbernalp reviewed Dec 10, 2025

View reviewed changes

machadovilaca and others added 3 commits December 17, 2025 13:02

Add persistent relabeled alerts rules (#5)

7f42262

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Add post API (#2)

be8cb4c

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Signed-off-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Add patch API (#4)

14d2066

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: João Vilaça <machadovilaca@gmail.com>

machadovilaca mentioned this pull request Jan 12, 2026

Add component mapping to alerts machadovilaca/monitoring-plugin#8

Open

sradco and others added 6 commits January 14, 2026 15:00

Update GET /alerts API filters to flat labels filtering format (#10)

8db3f3d

Signed-off-by: Shirly Radco <sradco@redhat.com>

Fix alertRelabelConfic logic (#9)

166d031

Signed-off-by: Shirly Radco <sradco@redhat.com>

Add owner label (#6)

f3f53f7

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Drop relabeled alert rules persistent configmap (#13)

ac423c6

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

Re-add missing metav1 import (#15)

97375a3

Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Add GitHub action unit tests (#16)

f3f2c6b

Signed-off-by: machadovilaca <machadovilaca@gmail.com>

simonpasquier reviewed Feb 5, 2026

View reviewed changes

.github/workflows/unit-tests.yaml

Copy link

Contributor

simonpasquier Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't have GitHub actions on github.com/openshift

Add to PATCH API drop and restore platform alerts (#12)

2c567fe

Signed-off-by: alitman <alitman@alitman-thinkpadp1gen7.raanaii.csb> Co-authored-by: Aviv Litman <alitman@alitman-thinkpadp1gen7.raanaii.csb>

Add const labels file (#17)

fb8a39d

Signed-off-by: Aviv Litman <alitman@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add base alert management API#657

Add base alert management API#657
machadovilaca wants to merge 14 commits intoopenshift:alerts-management-apifrom
machadovilaca:add-alert-management-api-base

machadovilaca commented Nov 25, 2025

Uh oh!

openshift-ci bot commented Nov 25, 2025

Uh oh!

machadovilaca commented Nov 25, 2025

Uh oh!

simonpasquier commented Nov 25, 2025

Uh oh!

simonpasquier left a comment •

edited

Loading

Uh oh!

machadovilaca commented Nov 26, 2025

Uh oh!

jgbernalp Dec 10, 2025

Uh oh!

simonpasquier Dec 10, 2025

Uh oh!

jgbernalp Dec 10, 2025

Uh oh!

jgbernalp Dec 10, 2025

Uh oh!

simonpasquier Feb 5, 2026

Uh oh!

coderabbitai bot commented Feb 16, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	featuresArg = flag.String("features", "", "enabled features, comma separated.\noptions: ['acm-alerting', 'incidents', 'dev-config', 'perses-dashboards', 'management-api']")
	featuresArg = flag.String("features", "", "enabled features, comma separated.\noptions: ['acm-alerting', 'incidents', 'dev-config', 'perses-dashboards', 'alert-management-api']")

Conversation

machadovilaca commented Nov 25, 2025

Uh oh!

openshift-ci bot commented Nov 25, 2025

Uh oh!

machadovilaca commented Nov 25, 2025

Uh oh!

simonpasquier commented Nov 25, 2025

Uh oh!

simonpasquier left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machadovilaca commented Nov 26, 2025

Uh oh!

jgbernalp Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

simonpasquier Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

jgbernalp Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

jgbernalp Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

simonpasquier Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Feb 16, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

simonpasquier left a comment •

edited

Loading