Skip to content

MCO-2147: Remove all remaining hardcoded references for TLS configuration#5747

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
djoshy:remove-cipher-order
Mar 6, 2026
Merged

MCO-2147: Remove all remaining hardcoded references for TLS configuration#5747
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
djoshy:remove-cipher-order

Conversation

@djoshy
Copy link
Copy Markdown
Contributor

@djoshy djoshy commented Mar 6, 2026

- What I did
Removed uncalled code that was previously used to hardcode a TLS configuration.

- How to verify it
This PR should have no effect on operator behavior, e2es should be sufficient to verify the behavior.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 6, 2026

@djoshy: This pull request references MCO-2147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
Removed uncalled code that was previously used to hardcode a TLS configuration.

- How to verify it
This PR should have no effect on operator behavior, e2es should be sufficient to verify the behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2026
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 6, 2026

/verified bypass

presubmits should be sufficient to verify this

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@djoshy: The verified label has been added.

Details

In response to this:

/verified bypass

presubmits should be sufficient to verify this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 6, 2026

/retest

Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cd082ec into openshift:main Mar 6, 2026
16 of 17 checks passed
@djoshy djoshy deleted the remove-cipher-order branch March 9, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants