Skip to content

MCO-2145: Disable skew enforcement on SNO clusters#5739

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
djoshy:disable-skew-sno
Mar 6, 2026
Merged

MCO-2145: Disable skew enforcement on SNO clusters#5739
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
djoshy:disable-skew-sno

Conversation

@djoshy
Copy link
Copy Markdown
Contributor

@djoshy djoshy commented Mar 4, 2026 •
edited
Loading

- What I did

  • Default skew enforcement to disabled on SNO clusters
  • Suppress the disabled mode Prometheus alert on SNO clusters.

- How to verify it
An SNO (TechPreview) cluster brought up on this PR should default to None mode. It should also not be propagating a skew enforcement related Prometheus alert while in None mode.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2026 •
edited by openshift-ci bot
Loading

@djoshy: This pull request references MCO-2145 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

  • Default skew enforcement to disabled on SNO clusters
  • Suppress the disabled mode Prometheus alert on SNO clusters.

- How to verify it
An SNO cluster brought up on this PR should default to None mode. It should also not be propagating a skew enforcement related Prometheus alert while in None mode.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2026
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 4, 2026

/retest

isabella-janssen
isabella-janssen reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 4, 2026

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 4, 2026 •
edited by openshift-ci bot
Loading

@djoshy: This pull request references MCO-2145 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

  • Default skew enforcement to disabled on SNO clusters
  • Suppress the disabled mode Prometheus alert on SNO clusters.

- How to verify it
An SNO (TechPreview) cluster brought up on this PR should default to None mode. It should also not be propagating a skew enforcement related Prometheus alert while in None mode.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2026
@djoshy djoshy force-pushed the disable-skew-sno branch from 9061cfc to 5003c99 Compare March 5, 2026 12:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2026
@djoshy djoshy force-pushed the disable-skew-sno branch from 5003c99 to 597024d Compare March 5, 2026 13:46
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 5, 2026

/retest-required

isabella-janssen
isabella-janssen reviewed Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sergiordlr
Copy link
Copy Markdown
Contributor

sergiordlr commented Mar 6, 2026 •
edited
Loading

Verified using AWS platform

  1. In IPI AWS HA all skew e2e test cases passed, including the alert one.

  2. In IPI AWS SNO

The default skew configuration is "None"

$ oc get machineconfiguration -oyaml
.....
  status:
    bootImageSkewEnforcementStatus:
      mode: None
...

And no MCCBootImageSkewEnforcementNone alert is reported because of that configuration

All tests with the exception of the automatic mode passed. Automatic mode tests need to be skipped in SNO clusters.

/verified by @sergiordlr

@sergiordlr
Copy link
Copy Markdown
Contributor

sergiordlr commented Mar 6, 2026

/verified by @sergiordlr

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 6, 2026

@sergiordlr: This PR has been marked as verified by @sergiordlr.

Details

In response to this:

/verified by @sergiordlr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 6, 2026 •
edited
Loading

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl-part2 597024d link false /test e2e-gcp-op-ocl-part2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 6, 2026 •
edited
Loading

/override ci/prow/hypershift

Has passed hypershift on this commit before and this PR should have no effect on that form factor generally

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 6, 2026

@djoshy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/hypershift

Only the following failed contexts/checkruns were expected:

  • ci/prow/bootstrap-unit
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-upgrade
  • ci/prow/e2e-gcp-op-ocl
  • ci/prow/e2e-gcp-op-ocl-part1
  • ci/prow/e2e-gcp-op-ocl-part2
  • ci/prow/e2e-gcp-op-part1
  • ci/prow/e2e-gcp-op-part2
  • ci/prow/e2e-gcp-op-single-node
  • ci/prow/e2e-hypershift
  • ci/prow/images
  • ci/prow/okd-scos-images
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-machine-config-operator-main-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn
  • pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade
  • pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl
  • pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl-part1
  • pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl-part2
  • pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-part1
  • pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-part2
  • pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-main-e2e-hypershift
  • pull-ci-openshift-machine-config-operator-main-images
  • pull-ci-openshift-machine-config-operator-main-okd-scos-images
  • pull-ci-openshift-machine-config-operator-main-security
  • pull-ci-openshift-machine-config-operator-main-unit
  • pull-ci-openshift-machine-config-operator-main-verify
  • pull-ci-openshift-machine-config-operator-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/hypershift

Has passed hypershift on this commit before and this PR should have on that form factor generally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Mar 6, 2026

/override ci/prow/e2e-hypershift

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 6, 2026

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ad1cf27 into openshift:main Mar 6, 2026
16 of 17 checks passed
@djoshy djoshy deleted the disable-skew-sno branch March 6, 2026 17:53
@djoshy djoshy mentioned this pull request Mar 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

1 more reviewer

@isabella-janssen isabella-janssen isabella-janssen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@isabella-janssen isabella-janssen

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@djoshy @openshift-ci-robot @sergiordlr @isabella-janssen @openshift-merge-robot