Skip to content

[release-4.19] OCPBUGS-77221: Prevent unnecessary systemd unit disable#5688

Open
isabella-janssen wants to merge 4 commits intoopenshift:release-4.19from
isabella-janssen:ocpbugs-58023-419
Open

[release-4.19] OCPBUGS-77221: Prevent unnecessary systemd unit disable#5688
isabella-janssen wants to merge 4 commits intoopenshift:release-4.19from
isabella-janssen:ocpbugs-58023-419

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Feb 24, 2026 •
edited
Loading

Closes: OCPBUGS-77221

- What I did
This is a manual cherrypick of #5664, which was needed due to the OCL and standard update paths being separate in <=4.19 (ref #4996 for 4.20 convergence of code path).

- How to verify it
See #5148 (comment) and #5612 (comment) for verification details.

- Description for the changelog
OCPBUGS-77221: Prevent unnecessary systemd unit disable

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/test verify

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/jira cherrypick OCPBUGS-76921

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2026

@isabella-janssen: Jira Issue OCPBUGS-76921 has been cloned as Jira Issue OCPBUGS-77221. Will retitle bug to link to clone.
/retitle OCPBUGS-77221: Prevent unnecessary systemd unit disable

Details

In response to this:

/jira cherrypick OCPBUGS-76921

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Prevent unnecessary systemd unit disable OCPBUGS-77221: Prevent unnecessary systemd unit disable Feb 24, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2026

@isabella-janssen: This pull request references Jira Issue OCPBUGS-77221, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: OCPBUGS-

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr February 24, 2026 14:05
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/retitle [release-4.19] OCPBUGS-77221: Prevent unnecessary systemd unit disable

@openshift-ci openshift-ci bot changed the title OCPBUGS-77221: Prevent unnecessary systemd unit disable [release-4.19] OCPBUGS-77221: Prevent unnecessary systemd unit disable Feb 24, 2026
@isabella-janssen isabella-janssen changed the base branch from main to release-4.19 February 24, 2026 14:06
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2026

@isabella-janssen: This pull request references Jira Issue OCPBUGS-77221, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.22.0" instead
  • expected dependent Jira Issue OCPBUGS-76921 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Closes: OCPBUGS-

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@RishabhSaini @isabella-janssen
helpers: compute systemdUnits that added and changed between Ign configs
cd32621 
update: only write added or updated systemd units unless forcefile exists then rewrite all systemd units
on_disk_validation: check if systemd units in config enabled correctly
tests: update MCN condition transition test to account for quick transitions through 'Unknown' state
(cherry picked from commit 4512ec4)
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/test verify

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/test verify

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/test verify

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/test verify

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 24, 2026

/test all

@isabella-janssen isabella-janssen marked this pull request as ready for review February 27, 2026 16:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2026
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 27, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2026

@isabella-janssen: This pull request references Jira Issue OCPBUGS-77221, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 27, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2026

@isabella-janssen: This pull request references Jira Issue OCPBUGS-77221, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-76921 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-76921 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Feb 27, 2026

/retest-required

@pablintino
Copy link
Contributor

pablintino commented Mar 2, 2026

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [isabella-janssen,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Mar 3, 2026

/test unit

1 similar comment
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Mar 3, 2026

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 4b8f17e link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Mar 5, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@pablintino pablintino

@lyman9966 lyman9966

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.