MCO-2033: Refactor bootstrap dependency handling #5519
Conversation
|
@pablintino: This pull request references MCO-2033 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
pablintino
force-pushed
the
mco-2033
branch
2 times, most recently
from
f761192 to
48688de
Compare
Extract file validation and dependency loading logic from RenderBootstrap into a dedicated bootstrap_dependencies.go file. This reduces cyclomatic complexity by separating input handling from rendering logic. This addresses complexity in the input handling path. Additional refactoring opportunities remain in other areas of the bootstrap logic.
|
@pablintino: This pull request references MCO-2033 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
The changes look fair and all the existing e2es are passing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Changes make sense and LGTM /verified bypass |
openshift-ci-robot
added
the
verified
|
@umohnani8: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/okd-scos-images Known issue, unrelated to MCO or this PR. (see coreos/rhel-coreos-config#134) |
|
@isabella-janssen: Overrode contexts on behalf of isabella-janssen: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-scos-images |
|
@isabella-janssen: Overrode contexts on behalf of isabella-janssen: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pablintino: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 36dcbbc
into
openshift:main
4 participants
- What I did
Extract file validation and dependency loading logic from RenderBootstrap into a dedicated bootstrap_dependencies.go file. This reduces cyclomatic complexity by separating input handling from rendering logic.
This addresses complexity in the input handling path. Additional refactoring opportunities remain in other areas of the bootstrap logic.
- How to verify it
E2Es for all platforms should be enough to test the bootstrap logic.
- Description for the changelog
Simplify the main operator bootstrap logic to reduce cyclomatic complexity.