Skip to content

update cert injection annotations to beta#1467

Open
lance5890 wants to merge 1 commit intoopenshift:mainfrom
lance5890:update_cert_injection_beta
Open

update cert injection annotations to beta#1467
lance5890 wants to merge 1 commit intoopenshift:mainfrom
lance5890:update_cert_injection_beta

Conversation

@lance5890
Copy link

@lance5890 lance5890 commented Mar 2, 2026

kubectl get svc -n openshift-machine-api machine-api-operator -oyaml
apiVersion: v1
kind: Service
metadata:
  annotations:
    capability.openshift.io/name: MachineAPI
    exclude.release.openshift.io/internal-openshift-hosted: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
    service.alpha.openshift.io/serving-cert-secret-name: machine-api-operator-tls
    service.alpha.openshift.io/serving-cert-signed-by: openshift-service-serving-signer@1772155313
    service.beta.openshift.io/serving-cert-signed-by: openshift-service-serving-signer@1772155313

Summary by CodeRabbit

  • Chores
    • Updated service certificate configuration for machine-api-operator and machine-api-controllers to align with current OpenShift standards.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 8846555 and 2191545.

📒 Files selected for processing (1)
  • install/0000_30_machine-api-operator_10_service.yaml

Walkthrough

The serving certificate secret annotation key was updated from alpha to beta version across two Kubernetes Service resources in the manifest file. The annotation service.alpha.openshift.io/serving-cert-secret-name was replaced with service.beta.openshift.io/serving-cert-secret-name for the machine-api-operator and machine-api-controllers Services.

Changes

Cohort / File(s) Summary
Annotation Key Migration
install/0000_30_machine-api-operator_10_service.yaml
Updated serving certificate secret annotation key from service.alpha.openshift.io/serving-cert-secret-name to service.beta.openshift.io/serving-cert-secret-name in two Service resources (machine-api-operator and machine-api-controllers).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating cert injection annotations from alpha to beta in the Service resources.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only Kubernetes YAML configuration file, not test code, making test naming requirement non-applicable.
Test Structure And Quality ✅ Passed The PR exclusively modifies a Kubernetes manifest file without adding, modifying, or removing any test code, making test quality requirements not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign damdo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant