-
Notifications
You must be signed in to change notification settings - Fork 35
OCPBUGS-66971: Ntpfailover backport 419 #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
OCPBUGS-66971: Ntpfailover backport 419 #511
Conversation
|
@josephdrichard: This pull request references Jira Issue OCPBUGS-66971, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josephdrichard The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Implement ntpfailover plugin to add support for failing over from GNSS to NTP as a time source for setting the system clock, in order to ensure at least some accuracy for the system clock even when GNSS is unavailable. When this plugin is enabled, phc2sys will be disabled upon loss of GNSS, and reenabled once GNSS becomes available again. Also, chronyd will be set to offline when GNSS is available, and then back online when GNSS stops being available. Note that this is scoped to only allowing failover when GNSS is configured as the primary source for the system clock, and does not support failover from PTP to NTP. Further work would be necessary to enable such a feature. Also add required interfaces to plugin framework and throughout daemon code to support this implementation.
12c7f14 to
af967be
Compare
|
/verified later @klaskosk |
|
@josephdrichard: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@josephdrichard: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
No description provided.