Skip to content

MG-138: Add datamasking service adapted from codeready-toolchain/tarsy-bot#2678

Closed
swghosh wants to merge 1 commit intoopenshift:mainfrom
swghosh:data-masking
Closed

MG-138: Add datamasking service adapted from codeready-toolchain/tarsy-bot#2678
swghosh wants to merge 1 commit intoopenshift:mainfrom
swghosh:data-masking

Conversation

@swghosh
Copy link
Copy Markdown
Member

@swghosh swghosh commented Dec 5, 2025

Description

Adds a data masking layer for MCP server request/response.

This implementation is blatantly adapted from https://github.com/codeready-toolchain/tarsy-bot/blob/master/backend/tarsy/services/data_masking_service.py.

Type of change

  • New feature
  • Optimization
Details

Masking available Pattern Groups:

Group Patterns Included
basic api_key, password
secrets api_key, password, token
security api_key, password, token, certificate, certificate_authority_data, email, ssh_key
kubernetes kubernetes_secret (code-based), api_key, password, certificate_authority_data
all All available patterns

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2025

@swghosh: This pull request references MG-138 which is a valid jira issue.

Details

In response to this:

Description

Adds a data masking layer for MCP server request/response.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2025

@swghosh: This pull request references MG-138 which is a valid jira issue.

Details

In response to this:

Description

Adds a data masking layer for MCP server request/response.

Type of change

  • New feature
  • Optimization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from bparees and xrajesh December 5, 2025 19:28
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign onmete for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2025
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2025

@swghosh: This pull request references MG-138 which is a valid jira issue.

Details

In response to this:

Description

Adds a data masking layer for MCP server request/response.

This implementation is blatantly adapted from https://github.com/codeready-toolchain/tarsy-bot/blob/master/backend/tarsy/services/data_masking_service.py.

Type of change

  • New feature
  • Optimization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2025

@swghosh: This pull request references MG-138 which is a valid jira issue.

Details

In response to this:

Description

Adds a data masking layer for MCP server request/response.

This implementation is blatantly adapted from https://github.com/codeready-toolchain/tarsy-bot/blob/master/backend/tarsy/services/data_masking_service.py.

Type of change

  • New feature
  • Optimization

Masking available Pattern Groups:

Group Patterns Included
basic api_key, password
secrets api_key, password, token
security api_key, password, token, certificate, certificate_authority_data, email, ssh_key
kubernetes kubernetes_secret (code-based), api_key, password, certificate_authority_data
all All available patterns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 5, 2025

@swghosh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 49b2aa3 link true /test integration
ci/prow/unit 49b2aa3 link true /test unit
ci/prow/verify 49b2aa3 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@onmete
Copy link
Copy Markdown
Contributor

onmete commented Jan 19, 2026

no activity

/close

@openshift-ci openshift-ci Bot closed this Jan 19, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 19, 2026

@onmete: Closed this PR.

Details

In response to this:

no activity

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants