CNTRLPLANE-3361: pluginlifecycle: treat transit-mount as required

[flavianmissi]

the api has changed to make this field required, so we change to reflect it.

Summary by CodeRabbit

• Bug Fixes
  • Sidecar initialization now consistently includes and requires the -transit-mount parameter; argument ordering for sidecar startup has been standardized.
• Tests
  • Test expectations and the mock plugin wrapper updated to reflect the new argument order and the required transit-mount validation.

[openshift-ci-robot]

@flavianmissi: This pull request references CNTRLPLANE-3361 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

the api has changed to make this field required, so we change to reflect it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ebb44d68-db20-485f-b13a-ab772bcbf056

📥 Commits

Reviewing files that changed from the base of the PR and between d53d047 and bbbdd50.

📒 Files selected for processing (4)

• pkg/operator/encryption/kms/pluginlifecycle/sidecar_test.go
• pkg/operator/encryption/kms/pluginlifecycle/vault.go
• pkg/operator/encryption/kms/pluginlifecycle/vault_test.go
• test/library/encryption/kms/k8s-mock-plugin/wrapper/main.go

✅ Files skipped from review due to trivial changes (1)

• pkg/operator/encryption/kms/pluginlifecycle/vault_test.go

🚧 Files skipped from review as they are similar to previous changes (1)

• test/library/encryption/kms/k8s-mock-plugin/wrapper/main.go

---

Walkthrough

Vault sidecar arg lists now always include -transit-mount; the mock plugin wrapper requires --transit-mount; unit and integration tests updated to match the new arg ordering and presence.

Changes

Transit Mount as Required Argument

Layer / File(s)	Summary
Vault sidecar builder arg construction pkg/operator/encryption/kms/pluginlifecycle/vault.go	BuildSidecarContainer now includes -transit-mount unconditionally in the required API fields argument list.
Vault sidecar unit test expectations pkg/operator/encryption/kms/pluginlifecycle/vault_test.go	Test expectations updated so -transit-mount=transit appears earlier in the arg sequence and is present in the empty-optional-fields case.
Sidecar integration test expectations pkg/operator/encryption/kms/pluginlifecycle/sidecar_test.go	Migration and standard sidecar expected Args ordering adjusted to place -transit-mount earlier.
Mock plugin wrapper validation requirement test/library/encryption/kms/k8s-mock-plugin/wrapper/main.go	CLI flag registration reordered; options.validate() now enforces --transit-mount as required and returns --transit-mount must be set when missing.

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• openshift/library-go#2223: Directly overlaps at the vault sidecar arg-building code and related tests concerning -transit-mount.
• openshift/library-go#2224: Modifies the same mock plugin wrapper CLI registration and validation for --transit-mount.

Suggested reviewers

• p0lyn0mial
• dgrisonnet

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	❓ Inconclusive	Check specifies Ginkgo test requirements (It blocks, BeforeEach), but PR uses standard Go testing with testify. Check inapplicable to this codebase's testing framework.	Clarify whether to assess Ginkgo patterns (not in repo) or standard Go tests. If assessing standard Go tests, some assertions lack meaningful messages (bare require.NoError calls).

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: treating transit-mount as required in the pluginlifecycle component.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Custom check not applicable. PR contains standard Go tests with table-driven test cases, not Ginkgo tests. No Ginkgo test declarations (It(), Describe(), etc.) found in the modified files.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies existing standard Go unit tests to update expected command-line argument ordering. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR modifies existing standard Go unit tests to update test expectations for command-line argument ordering and add validation.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies KMS plugin configuration to make transit-mount required. No changes to pod scheduling, affinity, node selectors, or topology-aware logic. Not applicable.
Ote Binary Stdout Contract	✅ Passed	PR modifies one binary (wrapper/main.go). Its main() uses Go's log package, which writes to stderr by default. No fmt.Print* to stdout. No klog violations.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. Changes are to unit tests and production code for KMS plugin configuration. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/library/encryption/kms/k8s-mock-plugin/wrapper/main.go`:
- Line 40: The help text for the --transit-mount flag is out of date: update the
flag.StringVar call that registers o.transitMount (flag name "transit-mount") to
remove the "(optional)" suffix and reflect that the transit mount is required so
the usage matches the validation logic (i.e., change the third argument string
to not include "(optional)").

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 52c3bf5f-2cb3-4a67-bd65-23660128a090

📥 Commits

Reviewing files that changed from the base of the PR and between dff948b and d53d047.

📒 Files selected for processing (4)

• pkg/operator/encryption/kms/pluginlifecycle/sidecar_test.go
• pkg/operator/encryption/kms/pluginlifecycle/vault.go
• pkg/operator/encryption/kms/pluginlifecycle/vault_test.go
• test/library/encryption/kms/k8s-mock-plugin/wrapper/main.go

[p0lyn0mial]

/assign @bertinatto

[openshift-ci]

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bertinatto]

/lgtm

and

/hold

for openshift/api#2847. We need that first because otherwise we could pass -transit-mount="" to the plugin, which would then fail to start. Not a big deal, but it'd break KMS tests in other PRs.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/operator/encryption/OWNERS [bertinatto]
• test/library/encryption/OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.