OCPBUGS-62422: staticpod/prune: Remove tmp cert file pruning by tchap · Pull Request #2053 · openshift/library-go

tchap · 2025-11-18T23:56:54Z

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

openshift-ci-robot · 2025-11-18T23:57:00Z

@tchap: This pull request references Jira Issue OCPBUGS-62422, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tchap · 2025-11-18T23:57:24Z

I am marking this as

/hold

to actually test this somewhere.

tchap · 2025-11-18T23:58:28Z

/jira refresh

openshift-ci-robot · 2025-11-18T23:58:35Z

@tchap: This pull request references Jira Issue OCPBUGS-62422, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tchap · 2025-11-20T09:57:01Z

 func NewPruneController(
 	targetNamespace string,
 	podResourcePrefix string,
-	certDir string,


This is no longer needed, but it also breaks the API 🤷🏻‍♂️

tchap · 2025-11-20T10:02:19Z

Well, I am not sure extra testing is worth it as we are only removing stuff. The WIP PR I created only contains Nothing to prune log entries.

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

openshift-ci · 2026-01-08T10:06:35Z

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

p0lyn0mial · 2026-01-08T13:40:30Z

/lgtm

we need to update kas-o, kcm-o, etcd-o and the scheduler to pick up the change.

openshift-ci · 2026-01-08T13:41:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/operator/staticpod/OWNERS~~ [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tchap · 2026-01-08T13:51:11Z

I will update the affected components.

kas-o: OCPBUGS-62422: deps: Update library-go to update pruner cluster-kube-apiserver-operator#1994
kcm-o: OCPBUGS-62422: dep: Update library-go to update pruner cluster-kube-controller-manager-operator#895
etcd-o: OCPBUGS-62422: deps: Update library-go to update pruner cluster-etcd-operator#1526
ksched-o: OCPBUGS-62422: deps: Update library-go to update pruner cluster-kube-scheduler-operator#593

/unhold

openshift-ci-robot · 2026-01-08T13:54:40Z

@tchap: Jira Issue OCPBUGS-62422: Some pull requests linked via external trackers have merged:

openshift/library-go#2053

The following pull request, linked via external tracker, has not merged:

openshift/cluster-kube-controller-manager-operator#895 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-62422 has not been moved to the MODIFIED state.

Details

In response to this:

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-01-14T11:15:58Z

Fix included in accepted release 4.22.0-0.nightly-2026-01-14-031657

openshift-ci Bot requested review from dgrisonnet and p0lyn0mial November 18, 2025 23:57

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2025

openshift-ci Bot requested a review from wangke19 November 18, 2025 23:58

tchap mentioned this pull request Nov 19, 2025

OCPBUGS-62422: dep: Update library-go to update pruner openshift/cluster-kube-controller-manager-operator#895

Merged

tchap commented Nov 20, 2025

View reviewed changes

p0lyn0mial reviewed Jan 8, 2026

View reviewed changes

Comment thread pkg/operator/staticpod/prune/cmd.go Outdated

Comment thread pkg/operator/staticpod/prune/cmd.go Outdated

staticpod/prune: Remove tmp cert file pruning

b9d4cad

This is no longer needed as pruning happens in relevant sync looks that actually write these certificates atomically.

tchap force-pushed the staticpod-pruner-tmp-certs branch from 36add39 to b9d4cad Compare January 8, 2026 09:46

openshift-ci Bot assigned p0lyn0mial Jan 8, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026

openshift-merge-bot Bot merged commit db8dbd6 into openshift:master Jan 8, 2026
4 checks passed

tchap deleted the staticpod-pruner-tmp-certs branch January 8, 2026 14:29

Conversation

tchap commented Nov 18, 2025

Uh oh!

openshift-ci-robot commented Nov 18, 2025

Uh oh!

tchap commented Nov 18, 2025

Uh oh!

tchap commented Nov 18, 2025

Uh oh!

openshift-ci-robot commented Nov 18, 2025

Uh oh!

tchap Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

tchap commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

openshift-ci Bot commented Jan 8, 2026

Uh oh!

p0lyn0mial commented Jan 8, 2026

Uh oh!

openshift-ci Bot commented Jan 8, 2026

Uh oh!

tchap commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 8, 2026

Uh oh!

openshift-merge-robot commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tchap commented Jan 8, 2026 •

edited

Loading