Skip to content

auditpolicycontroller: avoid unnecesary applyconfigmap calls#1987

Closed
vrutkovs wants to merge 2 commits intoopenshift:masterfrom
vrutkovs:auditpolicycontroller-lister
Closed

auditpolicycontroller: avoid unnecesary applyconfigmap calls#1987
vrutkovs wants to merge 2 commits intoopenshift:masterfrom
vrutkovs:auditpolicycontroller-lister

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Aug 4, 2025 •
edited
Loading

This would convert audit policy controller to use listers and compare contents with cached configmap to avoid extra apply calls.

Tested in openshift/cluster-kube-apiserver-operator#1886

@openshift-ci openshift-ci Bot requested review from p0lyn0mial and tkashem August 4, 2025 11:03
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the auditpolicycontroller-lister branch from 1fe75c8 to 3166f3b Compare August 4, 2025 12:46
@vrutkovs vrutkovs changed the title auditpolicycontroller: avoid unnecessray applyconfigmap calls WIP auditpolicycontroller: avoid unnecesary applyconfigmap calls Aug 4, 2025
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2025
@vrutkovs
auditpolicycontroller: avoid unnecessray applyconfigmap calls
a1cb8e0 
This would convert audit policy controller to use listers and compare contents with cached configmap
to avoid extra apply calls
@vrutkovs vrutkovs force-pushed the auditpolicycontroller-lister branch from 3166f3b to 936c427 Compare August 5, 2025 08:03
@vrutkovs
auditpolicycontroller: filter configmaps triggering this controller
0c1ebca 
Make sure that other configmap updates don't trigger auditpolicy controller - only target namespace
/ name configmap updates are making sync run. APIServer config and operator client informer events
are not being filtered
@vrutkovs vrutkovs force-pushed the auditpolicycontroller-lister branch from 936c427 to 0c1ebca Compare August 5, 2025 09:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 5, 2025

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs vrutkovs changed the title WIP auditpolicycontroller: avoid unnecesary applyconfigmap calls auditpolicycontroller: avoid unnecesary applyconfigmap calls Aug 5, 2025
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2025
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Nov 4, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2025
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Dec 4, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 4, 2025
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jan 4, 2026

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Jan 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 4, 2026

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@tkashem tkashem Awaiting requested review from tkashem

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vrutkovs @openshift-bot