OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct#2598
OCPBUGS-61465: Add a new field Mapped into openshift-test extension Image struct#2598jubittajohn wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
@jubittajohn: This pull request references Jira Issue OCPBUGS-61465, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jubittajohn: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jubittajohn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
./hack/update-vendor.sh Signed-off-by: jubittajohn <jujohn@redhat.com> UPSTREAM: <drop>: vendor update Signed-off-by: jubittajohn <jujohn@redhat.com>
b2f86b9 to
9529602
Compare
|
@jubittajohn: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
…on Image struct The new field Mapped contains all the same fields of Image resource that can be used later for openshift-tests images cmd to parse this Mapped key. The k8s-tests-ext will construct this Mapped key from GetMappedImageConfigs() function from upstream. Signed-off-by: jubittajohn <jujohn@redhat.com>
9529602 to
5d2cca9
Compare
|
@jubittajohn: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/retest |
1 similar comment
|
/retest |
|
@jubittajohn: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The current GetMappedImageConfigs returns the map with only mapped image config. The new func GetImageConfigsWithMappedImage will return original image information along with mapped one.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: