OCPBUGS-76516: 4.22 rebase v1.34.4#2591
OCPBUGS-76516: 4.22 rebase v1.34.4#2591jubittajohn wants to merge 84 commits intoopenshift:masterfrom
Conversation
Certain failures during SetupDevice and MapPodDevice are not treated as transient in the csi raw block plugin implementation, while they are in the file mode plugin. This can lead to certain failures causing volumes to be marked as unmounted incorrectly. This patch brings the block plugin up to parity with the fs one by marking the equivalent calls as transient. This mostly covers API server and some csi driver calls.
Fixes issue kubernetes#134023 where alpha API warnings were being logged when binary version (1.34.1) and emulation version (1.34) differed only in patch version. The issue was in api_enablement.go where the version comparison was using EqualTo() which compares all version components including patch versions. The fix changes the comparison to only check major.minor versions using version.MajorMinor(). Changes: - Modified version comparison logic in ApplyTo() method to only compare major.minor versions, not patch versions - Added comprehensive test cases to verify the fix works correctly - Tests confirm that warnings are still logged for different major/minor versions but not for different patch versions This prevents spurious warnings when emulation version is set to major.minor (e.g., 1.34) and binary version includes patch (e.g., 1.34.1).
Signed-off-by: Andrey Borovets <andrey.borovets@flant.com> add import Signed-off-by: Andrey Borovets <andrey.borovets@flant.com> delete import
…ess iptables Signed-off-by: Carlos Panato <ctadeu@gmail.com>
[release-1.34][go] Bump dependencies, images and versions used to Go 1.24.10 and distroless iptables
…pick-of-#135359-origin-release-1.34 Automated cherry pick of kubernetes#135359: Fallback to live ns lookup on admission if lister cannot find namespace
fix rsync IP address detection for v1.34
…-pick-of-#135327-upstream-release-1.34 Automated cherry pick of kubernetes#135327: Fix alpha API warnings for patch version differences
…ealFIFO are implementing it Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
…herry-pick-of-#135153-upstream-release-1.34 Automated cherry pick of kubernetes#135153: mark device manager as haelthy before it started for the first time
…pick-of-#135580-upstream-release-1.34 Automated cherry pick of kubernetes#135580 - Embed proper interface in TransformingStore
…ess iptables Signed-off-by: Carlos Panato <ctadeu@gmail.com>
[release-1.34][go] Bump dependencies, images and versions used to Go 1.24.11 and distroless iptables
…rol-plane-join-1-34 [Manual bugfix]: unhide the etcd-join phase for v1.34
…ick-of-#133599-upstream-release-1.34 Automated cherry pick of kubernetes#133599: Mark API server errors as transient in csi raw block driver
The kubekins image got updated from containerd 1.7 to 2.2, which broke local-up-cluster.sh in the CI because more recent containerd uses single quotation marks around strings instead of double quotation marks as before. The search/replaced with sed no longer matched, causing containerd to fail mounting overlayfs on the default /var/lib/containerd. We have to use the emptyDir host mount under /docker-graph. The fix is to relax the search term slightly so that it accepts both kinds of quotation marks.
`make` was printing the following warning on Ubuntu 25.10, which switched away from GNU coreutils to uutils: ``` !!! [1107 12:46:24] Failed to find GNU date as date or gdate. If you are on Mac: brew install coreutils. <GOPATH>/src/k8s.io/kubernetes/hack/lib/version.sh: line 166: DATE: unbound variable ``` Fix issue 135210 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit 0c0bc0d) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This metric got broken by caching efforts -- the value is counted only once.
If the user has provided extraArgs with an order that has significance (e.g. --service-account-issuer for kube-apiserver), kubeadm will correctly override any base args, but will end up sorting the entire resulting list, which is not desired. Instead, only sort the base arguments and preserve the order of overrides provided by the user.
…-of-#135692-origin-release-1.34 Automated cherry pick of kubernetes#135692: local-up-cluster.sh: support more recent containerd like 2.2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jacobsee, jubittajohn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/label acknowledge-critical-fixes-only |
|
/retitle OCPBUGS-76516: 4.22 rebase v1.34.4 |
|
@jubittajohn: This pull request references Jira Issue OCPBUGS-76516, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jacobsee: This pull request references Jira Issue OCPBUGS-76516, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
9 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@jubittajohn: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Bump release-4.22 to v1.34.4 from v1.34.2