Skip to content

OCPBUGS-76516: 4.22 rebase v1.34.4#2591

Open
jubittajohn wants to merge 84 commits intoopenshift:masterfrom
jubittajohn:4.22-rebase-v1.34.4
Open

OCPBUGS-76516: 4.22 rebase v1.34.4#2591
jubittajohn wants to merge 84 commits intoopenshift:masterfrom
jubittajohn:4.22-rebase-v1.34.4

Conversation

@jubittajohn
Copy link

Bump release-4.22 to v1.34.4 from v1.34.2

eltrufas and others added 30 commits November 3, 2025 15:47
Certain failures during SetupDevice and MapPodDevice are not treated as
transient in the csi raw block plugin implementation, while they are in
the file mode plugin. This can lead to certain failures causing volumes
to be marked as unmounted incorrectly.

This patch brings the block plugin up to parity with the fs one by
marking the equivalent calls as transient. This mostly covers API server
and some csi driver calls.
Fixes issue kubernetes#134023 where alpha API warnings were being logged
when binary version (1.34.1) and emulation version (1.34) differed
only in patch version.

The issue was in api_enablement.go where the version comparison
was using EqualTo() which compares all version components including
patch versions. The fix changes the comparison to only check
major.minor versions using version.MajorMinor().

Changes:
- Modified version comparison logic in ApplyTo() method to only
  compare major.minor versions, not patch versions
- Added comprehensive test cases to verify the fix works correctly
- Tests confirm that warnings are still logged for different
  major/minor versions but not for different patch versions

This prevents spurious warnings when emulation version is set to
major.minor (e.g., 1.34) and binary version includes patch (e.g., 1.34.1).
Signed-off-by: Andrey Borovets <andrey.borovets@flant.com>

add import

Signed-off-by: Andrey Borovets <andrey.borovets@flant.com>

delete import
…ess iptables

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
[release-1.34][go] Bump dependencies, images and versions used to Go 1.24.10 and distroless iptables
…pick-of-#135359-origin-release-1.34

Automated cherry pick of kubernetes#135359: Fallback to live ns lookup on admission if lister cannot find namespace
…-pick-of-#135327-upstream-release-1.34

Automated cherry pick of kubernetes#135327: Fix alpha API warnings for patch version differences
…ealFIFO are implementing it

Signed-off-by: Valerian Roche <valerian.roche@datadoghq.com>
…herry-pick-of-#135153-upstream-release-1.34

Automated cherry pick of kubernetes#135153: mark device manager as haelthy before it started for the first time
…pick-of-#135580-upstream-release-1.34

Automated cherry pick of kubernetes#135580 - Embed proper interface in TransformingStore
…ess iptables

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
[release-1.34][go] Bump dependencies, images and versions used to Go 1.24.11 and distroless iptables
…rol-plane-join-1-34

[Manual bugfix]: unhide the etcd-join phase for v1.34
…ick-of-#133599-upstream-release-1.34

Automated cherry pick of kubernetes#133599: Mark API server errors as transient in csi raw block driver
The kubekins image got updated from containerd 1.7 to 2.2, which broke
local-up-cluster.sh in the CI because more recent containerd uses single
quotation marks around strings instead of double quotation marks as before. The
search/replaced with sed no longer matched, causing containerd to fail mounting
overlayfs on the default /var/lib/containerd. We have to use the emptyDir host
mount under /docker-graph.

The fix is to relax the search term slightly so that it accepts both kinds of
quotation marks.
`make` was printing the following warning on Ubuntu 25.10,
which switched away from GNU coreutils to uutils:

```
!!! [1107 12:46:24] Failed to find GNU date as date or gdate. If you are on Mac: brew install coreutils.
<GOPATH>/src/k8s.io/kubernetes/hack/lib/version.sh: line 166: DATE: unbound variable
```

Fix issue 135210

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 0c0bc0d)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This metric got broken by caching efforts -- the value is counted only once.
If the user has provided extraArgs with an order that has
significance (e.g. --service-account-issuer for kube-apiserver),
kubeadm will correctly override any base args, but will end up
sorting the entire resulting list, which is not desired.

Instead, only sort the base arguments and preserve the order
of overrides provided by the user.
…-of-#135692-origin-release-1.34

Automated cherry pick of kubernetes#135692: local-up-cluster.sh: support more recent containerd like 2.2
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jacobsee, jubittajohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
@jacobsee
Copy link
Member

/retest

@jacobsee
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 19, 2026
@jacobsee
Copy link
Member

/retitle OCPBUGS-76516: 4.22 rebase v1.34.4

@openshift-ci openshift-ci bot changed the title 4.22 rebase v1.34.4 OCPBUGS-76516: 4.22 rebase v1.34.4 Feb 20, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2026
@openshift-ci-robot
Copy link

@jubittajohn: This pull request references Jira Issue OCPBUGS-76516, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump release-4.22 to v1.34.4 from v1.34.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jacobsee
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 20, 2026
@openshift-ci-robot
Copy link

@jacobsee: This pull request references Jira Issue OCPBUGS-76516, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gangwgr February 20, 2026 00:26
@jacobsee
Copy link
Member

/retest

9 similar comments
@jubittajohn
Copy link
Author

/retest

@jubittajohn
Copy link
Author

/retest

@jubittajohn
Copy link
Author

/retest

@jubittajohn
Copy link
Author

/retest

@jacobsee
Copy link
Member

/retest

@jubittajohn
Copy link
Author

/retest

@jacobsee
Copy link
Member

/retest

@jubittajohn
Copy link
Author

/retest

@jacobsee
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

@jubittajohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-runc 6c61d72 link true /test e2e-aws-ovn-runc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.