OCPBUGS-74511: remove RouteExternalCertificate feature gate#2585
OCPBUGS-74511: remove RouteExternalCertificate feature gate#2585jcmoraisjr wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@jcmoraisjr: This pull request references Jira Issue OCPBUGS-74511, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jcmoraisjr: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-ci
bot
requested review from
bertinatto,
melvinjoseph86 and
tkashem
| func NewRouteValidationOpts() *RouteValidationOpts { | ||
| return &RouteValidationOpts{ | ||
| opts: routecommon.RouteValidationOptions{ | ||
| AllowExternalCertificates: feature.DefaultMutableFeatureGate.Enabled(featuregate.Feature(openshiftfeatures.FeatureGateRouteExternalCertificate)), |
There was a problem hiding this comment.
Now that AllowExternalCertificates is always true; I think a proper cleanup would require removal of this field from the library-go as well.
There was a problem hiding this comment.
Just gave it a try: openshift/library-go#2122
|
Marking this PR as verified as this openshift/cluster-ingress-operator#1355 (comment) |
openshift-ci-robot
added
the
verified
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
| return &RouteValidationOpts{ | ||
| opts: routecommon.RouteValidationOptions{ | ||
| AllowExternalCertificates: feature.DefaultMutableFeatureGate.Enabled(featuregate.Feature(openshiftfeatures.FeatureGateRouteExternalCertificate)), | ||
| AllowExternalCertificates: true, |
There was a problem hiding this comment.
Please amend the commit to use the UPSTREAM: <carry>: ... pattern (see the README.openshift.md file in the root dir for details).
There was a problem hiding this comment.
Thanks @bertinatto. Can you confirm if my new commit follows the expected pattern correctly?
There was a problem hiding this comment.
Looks OK, @jcmoraisjr!
I'll tagging and leaving a hold so that Jacob can coordinate with the kube 1.35 merge.
@jacobsee feel free to remove the hold when you want to merge.
/lgtm
/remove-label backports/unvalidated-commits
RouteExternalCertificate is now enabled by default. This update is removing references to this feature gate, hardcoding its value to true. This update is also a pre-requisite to remove it from openshift/cluster-ingress-operator.
jcmoraisjr
force-pushed
the
OCPBUGS-74511-remove-featuregate
branch
from
70a02ad to
c223b83
Compare
openshift-ci-robot
removed
the
verified
|
@jcmoraisjr: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
|
@jcmoraisjr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
removed
the
backports/unvalidated-commits
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jcmoraisjr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/assign |
|
/test e2e-aws-crun-wasm |
|
/test e2e-gcp |
|
/test k8s-e2e-gcp-ovn |
|
@melvinjoseph86 I guess this needs a new verified |
6 participants
RouteExternalCertificate is now enabled by default. This update is removing references to this feature gate, hardcoding its value to true. This update is also a pre-requisite to remove it from openshift/cluster-ingress-operator.