Skip to content

MCO-2116: Generate OSImageStream manifest#10357

Draft
pablintino wants to merge 5 commits intoopenshift:mainfrom
pablintino:mco-2116
Draft

MCO-2116: Generate OSImageStream manifest#10357
pablintino wants to merge 5 commits intoopenshift:mainfrom
pablintino:mco-2116

Conversation

@pablintino
Copy link

When the OSStreams feature gate is enabled and the user has selected an OS image stream, generate the OSImageStream CR in the openshift manifests so the cluster can boot with the desired stream.

patrickdillon and others added 5 commits March 2, 2026 12:55
go get github.com/openshift/api@master
go mod tidy && go mod vendor
OpenShift API is now dividing feature gates by major version.
This updates the installer code to work with the new changes,
hardcoding the value to 4 as we do not have a design to dynamically
determine versions.
Make calls to determine if a feature gate is enabled more concise
by adding a dedicated helper function.
When the OSStreams feature gate is enabled and the user has selected
an OS image stream, generate the OSImageStream CR in the openshift
manifests so the cluster can boot with the desired stream.

Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 4, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2026

@pablintino: This pull request references MCO-2116 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

When the OSStreams feature gate is enabled and the user has selected an OS image stream, generate the OSImageStream CR in the openshift manifests so the cluster can boot with the desired stream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants