METAL-1750: baremetal: use q35 machine type with EFI firmware for bootstrap VM

[elfosardo]

The bootstrap VM domain definition did not set a machine type, causing libvirt to default to the deprecated pc-i440fx-rhel7.6.0 chipset on CentOS Stream 9 hosts. This has been correlated with intermittent bootstrap VM startup failures in CI where the VM becomes unreachable after QEMU starts.

Explicitly set the machine type to q35 with EFI firmware for x86_64, matching the pattern already used for aarch64 and aligning with how dev-scripts provisions master/worker VMs.

The arch-specific domain configuration is extracted into a separate configureDomainArch() function with unit tests.

Assisted-By: Claude 4.6 Opus High

[openshift-ci-robot]

@elfosardo: This pull request references METAL-1750 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The bootstrap VM domain definition did not set a machine type, causing libvirt to default to the deprecated pc-i440fx-rhel7.6.0 chipset on CentOS Stream 9 hosts. This has been correlated with intermittent bootstrap VM startup failures in CI where the VM becomes unreachable after QEMU starts.

Explicitly set the machine type to q35 with EFI firmware for x86_64, matching the pattern already used for aarch64 and aligning with how dev-scripts provisions master/worker VMs.

The arch-specific domain configuration is extracted into a separate configureDomainArch() function with unit tests.

Assisted-By: Claude 4.6 Opus High

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign iurygregory for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/infrastructure/baremetal/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/retest

[elfosardo]

/retest

[tdomnesc]

/lgtm

[dtantsur]

Looks good but conflicts with #9814 which should go in first. Sorry for the delay.

/approve
/hold

[elfosardo]

@dtantsur I'm ok merging #9814 first, JFYI this is needed to fix some flaky jobs in CI

[openshift-ci]

@elfosardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ovn-two-node-fencing	2399c31	link	false	/test e2e-metal-ovn-two-node-fencing

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[elfosardo]

/hold