no-jira: Bump openshift api#10347
Conversation
go get github.com/openshift/api@master
go mod tidy && go mod vendor
OpenShift API is now dividing feature gates by major version. This updates the installer code to work with the new changes, hardcoding the value to 4 as we do not have a design to dynamically determine versions.
Make calls to determine if a feature gate is enabled more concise by adding a dedicated helper function.
openshift-ci-robot
added
the
jira/valid-reference
|
@patrickdillon: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test golint |
|
/retest |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @sadasu @jhixson74 |
|
/approve |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 4006847
into
openshift:main
4 participants
OpenShift API is now dividing feature gates by major version. This updates the installer code to work with the new changes,
hardcoding the value to 4 as we do not have a design to dynamically determine versions.
Also refactors a helper function.