Skip to content

AGENT-1417: Add kind verification in InternalReleaseImage check #10332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Apr 13, 2026
+4 −2
Merged

AGENT-1417: Add kind verification in InternalReleaseImage check #10332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d299258
AGENT-1417: Improve min storage check for InternalReleaseImage
bfournie Feb 26, 2026
3bac111
AGENT-1417: Use registry.env to detect internal registry
bfournie Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions data/data/agent/files/usr/local/bin/configure-assisted-hw-requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ MASTER_DISK_SIZE=100
SNO_DISK_SIZE=100

# Increase disk size requirements for NoRegistryClusterInstall
if [ -f /etc/assisted/extra-manifests/internalreleaseimage.yaml ]; then
# Check if any file in extra-manifests contains kind: InternalReleaseImage
if [ -d /etc/assisted/extra-manifests ] && \
grep -q "^kind:[[:space:]]*InternalReleaseImage[[:space:]]*$" /etc/assisted/extra-manifests/* 2>/dev/null; then
MASTER_DISK_SIZE=220
SNO_DISK_SIZE=220
fi
Expand All @@ -17,4 +19,4 @@ fi
HW_VALIDATOR_REQUIREMENTS="[{\"version\":\"default\",\"master\":{\"cpu_cores\":4,\"ram_mib\":16384,\"disk_size_gb\":${MASTER_DISK_SIZE},\"installation_disk_speed_threshold_ms\":10,\"network_latency_threshold_ms\":100,\"packet_loss_percentage\":0},\"arbiter\":{\"cpu_cores\":2,\"ram_mib\":8192,\"disk_size_gb\":50,\"installation_disk_speed_threshold_ms\":10,\"network_latency_threshold_ms\":1000,\"packet_loss_percentage\":0},\"worker\":{\"cpu_cores\":2,\"ram_mib\":8192,\"disk_size_gb\":100,\"installation_disk_speed_threshold_ms\":10,\"network_latency_threshold_ms\":1000,\"packet_loss_percentage\":10},\"sno\":{\"cpu_cores\":8,\"ram_mib\":16384,\"disk_size_gb\":${SNO_DISK_SIZE},\"installation_disk_speed_threshold_ms\":10}}]"

# Replace the final value in the env file
sed -i "s|^HW_VALIDATOR_REQUIREMENTS=.*|HW_VALIDATOR_REQUIREMENTS=$HW_VALIDATOR_REQUIREMENTS|" "$ASSISTED_SERVICE_ENV_FILE"
sed -i "s|^HW_VALIDATOR_REQUIREMENTS=.*|HW_VALIDATOR_REQUIREMENTS=$HW_VALIDATOR_REQUIREMENTS|" "$ASSISTED_SERVICE_ENV_FILE"