CORS-4328: configure AWS CCM NodeIPFamilies for dual-stack support#10257
CORS-4328: configure AWS CCM NodeIPFamilies for dual-stack support#10257openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
Add NodeIPFamilies configuration to AWS cloud provider config when dual-stack networking is enabled. The cloud provider now sets the appropriate IP family ordering (ipv4/ipv6 or ipv6/ipv4) based on the install config's IPFamily setting. For dual-stack IPv4 primary clusters, NodeIPFamilies is set to: NodeIPFamilies=ipv4 NodeIPFamilies=ipv6 For dual-stack IPv6 primary clusters, NodeIPFamilies is set to: NodeIPFamilies=ipv6 NodeIPFamilies=ipv4 Single-stack IPv4 clusters continue to use the minimal config with an empty Global section.
openshift-ci-robot
added
the
jira/valid-reference
|
@tthvo: This pull request references CORS-4328 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
barbacbd,
patrickdillon,
sadasu and
yunjiang29
sadasu
left a comment
sadasu
left a comment
There was a problem hiding this comment.
+1 for compartmentalizing just 1 manifest update in 1 PR.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/verified by @tthvo (with CCCMO PR#426) |
openshift-ci-robot
added
the
verified
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tthvo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
This PR adds
NodeIPFamiliesconfiguration to AWS cloud provider config when dual-stack networking is enabled. The cloud provider now sets the appropriate IP family ordering (ipv4/ipv6 or ipv6/ipv4) based on the install config'sipFamilysetting. Tested and extracted from #9930.For dual-stack IPv4 primary clusters, NodeIPFamilies is set to:
For dual-stack IPv6 primary clusters, NodeIPFamilies is set to:
Single-stack IPv4 clusters continue to use the minimal config with an empty Global section.
[Global]Note: The installer lays down the correct format. However, CCCMO modifies the format of the
NodeIPFamiliesentries incorrectly in-cluster. The PR openshift/cluster-cloud-controller-manager-operator#426 will fix that.