NO-JIRA: Add review process docs to CONTRIBUTING.md by clebs · Pull Request #7426 · openshift/hypershift

clebs · 2026-01-05T15:29:55Z

What this PR does / why we need it:

This PR adds documentation regarding the review process in a concise way with clear examples.

Checklist:

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2026-01-05T15:29:59Z

@clebs: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

This PR adds documentation regarding the review process in a concise way with clear examples.

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-01-05T15:30:00Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-01-05T15:30:03Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

clebs · 2026-01-05T15:31:57Z

/area documentation

clebs · 2026-01-05T15:33:08Z

/auto-cc

clebs · 2026-01-05T15:34:27Z

/test verify images okd-scos-images

bryan-cox

Added a few comments

bryan-cox · 2026-01-06T18:19:21Z

/approve

openshift-ci · 2026-01-06T18:19:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, clebs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Borja Clemente <bclement@redhat.com>

clebs · 2026-01-08T09:08:56Z

/test all

clebs · 2026-01-09T15:14:05Z

/verified bypass

Docs only change.

openshift-ci-robot · 2026-01-09T15:14:18Z

@clebs: The verified label has been added.

Details

In response to this:

/verified bypass

Docs only change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

muraee · 2026-01-12T13:12:28Z

/lgtm

openshift-ci · 2026-01-12T13:33:31Z

@clebs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

clebs · 2026-01-12T13:45:12Z

/test hypershift-cli-mce-211

openshift-ci · 2026-01-12T13:45:15Z

@clebs: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aks

/test e2e-aks-4-21

/test e2e-aks-override

/test e2e-aws

/test e2e-aws-4-21

/test e2e-aws-override

/test e2e-aws-upgrade-hypershift-operator

/test e2e-kubevirt-aws-ovn-reduced

/test images

/test okd-scos-images

/test security

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-autonode

/test e2e-aws-metrics

/test e2e-aws-minimal

/test e2e-aws-techpreview

/test e2e-azure-aks-ovn-conformance

/test e2e-conformance

/test e2e-kubevirt-aws-ovn

/test e2e-kubevirt-azure-ovn

/test e2e-kubevirt-metal-conformance

/test e2e-openstack-aws

/test e2e-openstack-aws-conformance

/test e2e-openstack-aws-csi-cinder

/test e2e-openstack-aws-csi-manila

/test e2e-openstack-aws-nfv

/test okd-scos-e2e-aws-ovn

/test reqserving-e2e-aws

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-hypershift-main-images

pull-ci-openshift-hypershift-main-okd-scos-images

pull-ci-openshift-hypershift-main-verify

Details

In response to this:

/test hypershift-cli-mce-211

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

clebs · 2026-01-12T13:47:53Z

/test enterprise-contract-mce-211/hypershift-cli-mce-211

openshift-ci · 2026-01-12T13:47:57Z

@clebs: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aks

/test e2e-aks-4-21

/test e2e-aks-override

/test e2e-aws

/test e2e-aws-4-21

/test e2e-aws-override

/test e2e-aws-upgrade-hypershift-operator

/test e2e-kubevirt-aws-ovn-reduced

/test images

/test okd-scos-images

/test security

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-aws-autonode

/test e2e-aws-metrics

/test e2e-aws-minimal

/test e2e-aws-techpreview

/test e2e-azure-aks-ovn-conformance

/test e2e-conformance

/test e2e-kubevirt-aws-ovn

/test e2e-kubevirt-azure-ovn

/test e2e-kubevirt-metal-conformance

/test e2e-openstack-aws

/test e2e-openstack-aws-conformance

/test e2e-openstack-aws-csi-cinder

/test e2e-openstack-aws-csi-manila

/test e2e-openstack-aws-nfv

/test okd-scos-e2e-aws-ovn

/test reqserving-e2e-aws

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-hypershift-main-images

pull-ci-openshift-hypershift-main-okd-scos-images

pull-ci-openshift-hypershift-main-verify

Details

In response to this:

/test enterprise-contract-mce-211/hypershift-cli-mce-211

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bryan-cox · 2026-01-12T13:53:59Z

/override "Red Hat Konflux / enterprise-contract-mce-211 / hypershift-cli-mce-211"

openshift-ci · 2026-01-12T13:54:49Z

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / enterprise-contract-mce-211 / hypershift-cli-mce-211

Details

In response to this:

/override "Red Hat Konflux / enterprise-contract-mce-211 / hypershift-cli-mce-211"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 5, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2026

openshift-ci Bot added the do-not-merge/needs-area label Jan 5, 2026

openshift-ci Bot added area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Jan 5, 2026

openshift-ci Bot requested review from jparrill and muraee January 5, 2026 15:33

bryan-cox reviewed Jan 5, 2026

View reviewed changes

Comment thread .github/CONTRIBUTING.md Outdated

Comment thread .github/CONTRIBUTING.md Outdated

Comment thread .github/CONTRIBUTING.md Outdated

muraee reviewed Jan 5, 2026

View reviewed changes

Comment thread .github/CONTRIBUTING.md Outdated

clebs force-pushed the contrib-review-process branch from 73e4312 to 1dab760 Compare January 5, 2026 17:33

bryan-cox reviewed Jan 6, 2026

View reviewed changes

Comment thread .github/CONTRIBUTING.md

Comment thread .github/CONTRIBUTING.md Outdated

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2026

docs(contributing): Add review process docs to CONTRIBUTING.md

2122fad

Signed-off-by: Borja Clemente <bclement@redhat.com>

clebs force-pushed the contrib-review-process branch from 1dab760 to 2122fad Compare January 7, 2026 15:00

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 9, 2026

clebs marked this pull request as ready for review January 12, 2026 13:13

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2026

openshift-ci Bot assigned muraee Jan 12, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026

openshift-ci Bot requested review from muraee and sjenning January 12, 2026 13:16

openshift-merge-bot Bot merged commit ed9c78c into openshift:main Jan 12, 2026
9 of 10 checks passed

clebs deleted the contrib-review-process branch January 12, 2026 13:57

Conversation

clebs commented Jan 5, 2026

What this PR does / why we need it:

Checklist:

Uh oh!

openshift-ci-robot commented Jan 5, 2026

What this PR does / why we need it:

Checklist:

Uh oh!

openshift-ci Bot commented Jan 5, 2026

Uh oh!

coderabbitai Bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

clebs commented Jan 5, 2026

Uh oh!

clebs commented Jan 5, 2026

Uh oh!

clebs commented Jan 5, 2026

Uh oh!

bryan-cox left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bryan-cox commented Jan 6, 2026

Uh oh!

openshift-ci Bot commented Jan 6, 2026

Uh oh!

clebs commented Jan 8, 2026

Uh oh!

clebs commented Jan 9, 2026

Uh oh!

openshift-ci-robot commented Jan 9, 2026

Uh oh!

muraee commented Jan 12, 2026

Uh oh!

openshift-ci Bot commented Jan 12, 2026

Uh oh!

clebs commented Jan 12, 2026

Uh oh!

openshift-ci Bot commented Jan 12, 2026

Uh oh!

clebs commented Jan 12, 2026

Uh oh!

openshift-ci Bot commented Jan 12, 2026

Uh oh!

bryan-cox commented Jan 12, 2026

Uh oh!

openshift-ci Bot commented Jan 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Jan 5, 2026 •

edited

Loading