forked from vmware-archive/eventrouter
-
Notifications
You must be signed in to change notification settings - Fork 42
Update dependencies #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erpel
wants to merge
6
commits into
openshift:master
Choose a base branch
from
erpel:update_deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d5fd3aa
Update dependencies
erpel 4499583
Keep FatalF but add format string to fix error.
erpel bd63ce0
Update builder docker image.
erpel 7a9e38f
Use plain golang image for build
erpel c322016
Use specific version for builder
erpel c8c1b5e
Update dependencies
erpel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,88 +1,85 @@ | ||
| module github.com/openshift/eventrouter | ||
|
|
||
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.4 | ||
| go 1.24.0 | ||
|
|
||
| require ( | ||
| github.com/Shopify/sarama v1.23.1 | ||
| github.com/crewjam/rfc5424 v0.0.0-20180723152949-c25bdd3a0ba2 | ||
| github.com/IBM/sarama v1.46.3 | ||
| github.com/crewjam/rfc5424 v0.1.0 | ||
| github.com/eapache/channels v1.1.0 | ||
| github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b | ||
| github.com/prometheus/client_golang v1.19.1 | ||
| github.com/sethgrid/pester v0.0.0-20190127155807-68a33a018ad0 | ||
| github.com/spf13/viper v1.4.0 | ||
| k8s.io/api v0.32.2 | ||
| k8s.io/apimachinery v0.32.2 | ||
| k8s.io/client-go v0.32.2 | ||
| github.com/golang/glog v1.2.5 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| github.com/sethgrid/pester v1.2.0 | ||
| github.com/spf13/viper v1.21.0 | ||
| k8s.io/api v0.34.4 | ||
| k8s.io/apimachinery v0.34.4 | ||
| k8s.io/client-go v0.34.4 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/DataDog/zstd v1.3.6-0.20190409195224-796139022798 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/cespare/xxhash/v2 v2.2.0 // indirect | ||
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
| github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||
| github.com/eapache/go-resiliency v1.1.0 // indirect | ||
| github.com/eapache/go-xerial-snappy v0.0.0-20180814174437-776d5712da21 // indirect | ||
| github.com/eapache/go-resiliency v1.7.0 // indirect | ||
| github.com/eapache/go-xerial-snappy v0.0.0-20230731223053-c322873962e3 // indirect | ||
| github.com/eapache/queue v1.1.0 // indirect | ||
| github.com/emicklei/go-restful/v3 v3.11.0 // indirect | ||
| github.com/fsnotify/fsnotify v1.4.9 // indirect | ||
| github.com/fxamacker/cbor/v2 v2.7.0 // indirect | ||
| github.com/go-logr/logr v1.4.2 // indirect | ||
| github.com/go-openapi/jsonpointer v0.21.0 // indirect | ||
| github.com/go-openapi/jsonreference v0.20.2 // indirect | ||
| github.com/go-openapi/swag v0.23.0 // indirect | ||
| github.com/emicklei/go-restful/v3 v3.12.2 // indirect | ||
| github.com/fsnotify/fsnotify v1.9.0 // indirect | ||
| github.com/fxamacker/cbor/v2 v2.9.0 // indirect | ||
| github.com/go-logr/logr v1.4.3 // indirect | ||
| github.com/go-openapi/jsonpointer v0.21.2 // indirect | ||
| github.com/go-openapi/jsonreference v0.20.5 // indirect | ||
| github.com/go-openapi/swag v0.23.1 // indirect | ||
| github.com/go-viper/mapstructure/v2 v2.4.0 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/golang/protobuf v1.5.4 // indirect | ||
| github.com/golang/snappy v0.0.1 // indirect | ||
| github.com/google/gnostic-models v0.6.8 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| github.com/google/gofuzz v1.2.0 // indirect | ||
| github.com/golang/snappy v1.0.0 // indirect | ||
| github.com/google/gnostic-models v0.7.1 // indirect | ||
| github.com/google/go-cmp v0.7.0 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/hashicorp/go-uuid v1.0.1 // indirect | ||
| github.com/hashicorp/hcl v1.0.0 // indirect | ||
| github.com/jcmturner/gofork v0.0.0-20190328161633-dc7c13fece03 // indirect | ||
| github.com/hashicorp/go-uuid v1.0.3 // indirect | ||
| github.com/jcmturner/aescts/v2 v2.0.0 // indirect | ||
| github.com/jcmturner/dnsutils/v2 v2.0.0 // indirect | ||
| github.com/jcmturner/gofork v1.7.6 // indirect | ||
| github.com/jcmturner/gokrb5/v8 v8.4.4 // indirect | ||
| github.com/jcmturner/rpc/v2 v2.0.3 // indirect | ||
| github.com/josharian/intern v1.0.0 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/magiconair/properties v1.8.0 // indirect | ||
| github.com/mailru/easyjson v0.7.7 // indirect | ||
| github.com/mitchellh/mapstructure v1.1.2 // indirect | ||
| github.com/klauspost/compress v1.18.4 // indirect | ||
| github.com/mailru/easyjson v0.9.1 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.2 // indirect | ||
| github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect | ||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
| github.com/pelletier/go-toml v1.2.0 // indirect | ||
| github.com/pierrec/lz4 v0.0.0-20190327172049-315a67e90e41 // indirect | ||
| github.com/pelletier/go-toml/v2 v2.2.4 // indirect | ||
| github.com/pierrec/lz4/v4 v4.1.25 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/prometheus/client_model v0.5.0 // indirect | ||
| github.com/prometheus/common v0.48.0 // indirect | ||
| github.com/prometheus/procfs v0.12.0 // indirect | ||
| github.com/rcrowley/go-metrics v0.0.0-20181016184325-3113b8401b8a // indirect | ||
| github.com/spf13/afero v1.2.2 // indirect | ||
| github.com/spf13/cast v1.3.0 // indirect | ||
| github.com/spf13/jwalterweatherman v1.0.0 // indirect | ||
| github.com/spf13/pflag v1.0.5 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/prometheus/client_model v0.6.2 // indirect | ||
| github.com/prometheus/common v0.66.1 // indirect | ||
| github.com/prometheus/procfs v0.16.1 // indirect | ||
| github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9 // indirect | ||
| github.com/sagikazarmark/locafero v0.12.0 // indirect | ||
| github.com/spf13/afero v1.15.0 // indirect | ||
| github.com/spf13/cast v1.10.0 // indirect | ||
| github.com/spf13/pflag v1.0.10 // indirect | ||
| github.com/subosito/gotenv v1.6.0 // indirect | ||
| github.com/x448/float16 v0.8.4 // indirect | ||
| golang.org/x/crypto v0.28.0 // indirect | ||
| golang.org/x/net v0.30.0 // indirect | ||
| golang.org/x/oauth2 v0.23.0 // indirect | ||
| golang.org/x/sys v0.26.0 // indirect | ||
| golang.org/x/term v0.25.0 // indirect | ||
| golang.org/x/text v0.19.0 // indirect | ||
| golang.org/x/time v0.7.0 // indirect | ||
| google.golang.org/protobuf v1.35.1 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.3 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| golang.org/x/crypto v0.43.0 // indirect | ||
| golang.org/x/net v0.46.0 // indirect | ||
| golang.org/x/oauth2 v0.30.0 // indirect | ||
| golang.org/x/sys v0.37.0 // indirect | ||
| golang.org/x/term v0.36.0 // indirect | ||
| golang.org/x/text v0.30.0 // indirect | ||
| golang.org/x/time v0.9.0 // indirect | ||
| google.golang.org/protobuf v1.36.11 // indirect | ||
| gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/jcmturner/aescts.v1 v1.0.1 // indirect | ||
| gopkg.in/jcmturner/dnsutils.v1 v1.0.1 // indirect | ||
| gopkg.in/jcmturner/goidentity.v3 v3.0.0 // indirect | ||
| gopkg.in/jcmturner/gokrb5.v7 v7.2.3 // indirect | ||
| gopkg.in/jcmturner/rpc.v1 v1.1.0 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| k8s.io/klog/v2 v2.130.1 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f // indirect | ||
| k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect | ||
| sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect | ||
| sigs.k8s.io/yaml v1.4.0 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20260127142750-a19766b6e2d4 // indirect | ||
| k8s.io/utils v0.0.0-20260210185600-b8788abfbbc2 // indirect | ||
| sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect | ||
| sigs.k8s.io/randfill v1.0.0 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v6 v6.3.2 // indirect | ||
| sigs.k8s.io/yaml v1.6.0 // indirect | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should require a Dockerfile update https://github.com/openshift/eventrouter/blob/master/Dockerfile#L1 and I am uncertain if our product tooling has this image available. cc @xperimental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed with updated builder image, but had to do this blindly as that registry is not browsable for me.
If 1.24 is absolutely not available, I could try to update deps to versions that work with 1.23 but getting it to work with 1.24 seems better for the long term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcantrill I could change the builder image to a plain upstream
FROM golang AS builder- it does build without issue in our pipelines.Would that be an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will not pass until openshift/release#70571 merges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the question about availability of a Go 1.24 image is solved already, but I had a comment on another part of the PR.