WIP: CVO configuration: Minor refactoring and changes #1234
Conversation
Utilize a new structure, which holds the relevant information regarding the desired CVO configuration and its status to encapsulate this information to a simple data structure.
Using the field we can avoid changing the actual logging during testing by assigning a different function to the field if necessary. We can now also verify that the handler field is being executed.
The information regarding enabled feature gates is now available sooner in the code. Utilize this information to conditionally initialize the configuration controller at a one specific place. If no configuration controller is needed, this information is clearly stated by the noninitialized configuration field. The subsequent code can then easily check for existence of the configuration using a nil.
An error in the start logic will now result in the immediate shutdown of the CVO, rather than in the CVO catching the failed controller and continuing to work by ignoring the failed start.
Due to recent changes, the two test functions can now be safely merged together. The second function verified the overall synchronization of the configuration, which is now also being exercised in the first function. The tests cases were migrated over to the first function or were already present.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidHurta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@DavidHurta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Blocked by #1232 |
|
/cc |
|
/uncc |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
3 participants
No description provided.