[wip]test-only; no-merge

[hongkailiu]

The same way as openshift/cluster-csi-snapshot-controller-operator#249 to generate the pull.

[hongkailiu]

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade openshift/origin#30296

[openshift-ci]

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ff090370-a91a-11f0-871f-bd6b682d5885-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

This PR fixes all Progressing condition of all Deployments initiated by cluster-storage-operator. These don't have prefix GCPPDCSIDriverOperatorCR. I.e. VolumeDataSourceValidatorDeploymentControllerProgressing and GCPPDProgressing. And I think this PR helped in this sense.

To get rid of all bad Progressing conditions on GCE, we will need to bump library-go in https://github.com/openshift/gcp-pd-csi-driver-operator/
And we will need to bump library-go in many similar repos, only storage has ~10 of them. I would prefer to do that post-merge.

[jsafrane]

I bumped library-go in the GCP PD CSI driver operator repo: openshift/gcp-pd-csi-driver-operator#152

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade openshift/origin#30296 openshift/gcp-pd-csi-driver-operator#152

[jsafrane]

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade openshift/origin#30296 openshift/gcp-pd-csi-driver-operator#152

[openshift-ci]

@jsafrane: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[jsafrane]

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade openshift/origin#30296 openshift/gcp-pd-csi-driver-operator#152

[openshift-ci]

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7754db70-a9b5-11f0-9995-43ccff57d2e9-0

[jsafrane]

hmm, it's still not 100% clean, but the nr. of progressing controllers is significantly lower:

Oct 15 13:26:07.884 W clusteroperator/storage condition/Progressing reason/GCPPD_Deploying status/True GCPPDProgressing: Waiting for Deployment to deploy pods (exception: https://issues.redhat.com/browse/OCPBUGS-62634)
Oct 15 13:26:07.884 - 15s   W clusteroperator/storage condition/Progressing reason/GCPPD_Deploying status/True GCPPDProgressing: Waiting for Deployment to deploy pods (exception: https://issues.redhat.com/browse/OCPBUGS-62634)
Oct 15 13:32:39.336 W clusteroperator/storage condition/Progressing reason/GCPPD_Deploying status/True GCPPDProgressing: Waiting for Deployment to deploy pods (exception: https://issues.redhat.com/browse/OCPBUGS-62634)
Oct 15 13:32:39.336 - 2s    W clusteroperator/storage condition/Progressing reason/GCPPD_Deploying status/True GCPPDProgressing: Waiting for Deployment to deploy pods (exception: https://issues.redhat.com/browse/OCPBUGS-62634)

I will check where GCPPD_Deploying status/True tomorrow.

[jsafrane]

I ended up with #635

[jsafrane]

/close
#639 has all the PRs and passed testing with openshift/origin#30296

[openshift-ci]

@jsafrane: Closed this PR.

Details

In response to this:

/close
#639 has all the PRs and passed testing with openshift/origin#30296

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.