Skip to content

CNTRLPLANE-2619: make checkendpoints use apiserver config#657

Open
ricardomaraschini wants to merge 1 commit intoopenshift:mainfrom
ricardomaraschini:CNTRLPLANE-2619-OPERAND
Open

CNTRLPLANE-2619: make checkendpoints use apiserver config#657
ricardomaraschini wants to merge 1 commit intoopenshift:mainfrom
ricardomaraschini:CNTRLPLANE-2619-OPERAND

Conversation

@ricardomaraschini
Copy link
Contributor

in order to make the check-endpoints container to respect the global tls config we need to make it point to a config where the tls is present.

the check-endpoints container accepts a --config flag, such flag points to a file containing a OpenShiftAPIServerConfig.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2026

@ricardomaraschini: This pull request references CNTRLPLANE-2619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

in order to make the check-endpoints container to respect the global tls config we need to make it point to a config where the tls is present.

the check-endpoints container accepts a --config flag, such flag points to a file containing a OpenShiftAPIServerConfig.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
Once this PR has been reviewed and has the lgtm label, please assign sanchezl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini
Copy link
Contributor Author

/retest

1 similar comment
@ricardomaraschini
Copy link
Contributor Author

/retest

@ricardomaraschini
Copy link
Contributor Author

The fault does not seem to be related.

/retest

@ricardomaraschini
Copy link
Contributor Author

This approach is causing issues on IPv6. Putting it on hold.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2026
@ricardomaraschini
Copy link
Contributor Author

/retest

in order to make the check-endpoints container to respect the global tls
config we need to make it point to a config where the tls is present.

the check-endpoints container accepts a --config flag, such flag points
to a file containing a OpenShiftAPIServerConfig.
@ricardomaraschini ricardomaraschini force-pushed the CNTRLPLANE-2619-OPERAND branch from 17339fc to 58e4e69 Compare March 2, 2026 11:39
@ricardomaraschini
Copy link
Contributor Author

@gangwgr @kaleemsiddiqu This one also needs proper IPv6 validation.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

@ricardomaraschini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 58e4e69 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants