CNTRLPLANE-2619: make checkendpoints use apiserver config#657
CNTRLPLANE-2619: make checkendpoints use apiserver config#657ricardomaraschini wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@ricardomaraschini: This pull request references CNTRLPLANE-2619 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
aedba71 to
17339fc
Compare
|
/retest |
1 similar comment
|
/retest |
|
The fault does not seem to be related. /retest |
|
This approach is causing issues on IPv6. Putting it on hold. /hold |
|
/retest |
in order to make the check-endpoints container to respect the global tls config we need to make it point to a config where the tls is present. the check-endpoints container accepts a --config flag, such flag points to a file containing a OpenShiftAPIServerConfig.
17339fc to
58e4e69
Compare
|
@gangwgr @kaleemsiddiqu This one also needs proper IPv6 validation. |
|
@ricardomaraschini: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
in order to make the check-endpoints container to respect the global tls config we need to make it point to a config where the tls is present.
the check-endpoints container accepts a --config flag, such flag points to a file containing a OpenShiftAPIServerConfig.