Skip to content

CNTRLPLANE-2241: Update library-go to get KMS encryption#647

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ardaguclu:fake-bump
Feb 24, 2026
Merged

CNTRLPLANE-2241: Update library-go to get KMS encryption#647
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ardaguclu:fake-bump

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Feb 6, 2026

This PR is to update library-go to get openshift/library-go#2086

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ardaguclu ardaguclu marked this pull request as ready for review February 6, 2026 07:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2026
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial February 6, 2026 07:47
@ardaguclu ardaguclu force-pushed the fake-bump branch 3 times, most recently from 8dbd959 to a2642af Compare February 17, 2026 09:56
@ardaguclu ardaguclu changed the title Fake bump to test kms CNTRLPLANE-2241: Update library-go to get KMS encryption Feb 23, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 23, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2026

@ardaguclu: This pull request references CNTRLPLANE-2241 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2026

@ardaguclu: This pull request references CNTRLPLANE-2241 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR is to update library-go to get openshift/library-go#2086

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial
Copy link
Contributor

/lgtm

/hold

let's wait for the encryption (optional) CI jobs.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2026
@ardaguclu
Copy link
Member Author

Cluster bootstrap error
/test e2e-gcp-operator-encryption-kms

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2026

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gangwgr
Copy link
Contributor

gangwgr commented Feb 24, 2026

/verified by e2e-gcp-operator-encryption-kms ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 24, 2026
@openshift-ci-robot
Copy link

@gangwgr: This PR has been marked as verified by e2e-gcp-operator-encryption-kms ci.

Details

In response to this:

/verified by e2e-gcp-operator-encryption-kms ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu
Copy link
Member Author

This can be considered a safe change because imported changes can only be used by enabling KMSEncryption feature gate AND KMS encryption mode on apiserver.config.openshift.io. Besides, this is important functionality we want to deliver soon to immediately start working on TechPreview v2.
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 24, 2026
@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit ad79962 into openshift:main Feb 24, 2026
14 checks passed
@ardaguclu ardaguclu deleted the fake-bump branch February 24, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants