Skip to content

WIP: Fake vendor library-go#639

Closed
ardaguclu wants to merge 1 commit intoopenshift:mainfrom
ardaguclu:fake-kms-mode
Closed

WIP: Fake vendor library-go#639
ardaguclu wants to merge 1 commit intoopenshift:mainfrom
ardaguclu:fake-kms-mode

Conversation

@ardaguclu
Copy link
Copy Markdown
Member

This PR is fake bump to get the changes in openshift/library-go#2086

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
@openshift-ci openshift-ci Bot requested review from dgrisonnet and tkashem January 23, 2026 09:20
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2026

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Copy Markdown
Member Author

I'm closing these fake bumps. There are many changes in library-go already. So we'll need to merge them all.
/close

@openshift-ci openshift-ci Bot closed this Jan 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 29, 2026

@ardaguclu: Closed this PR.

Details

In response to this:

I'm closing these fake bumps. There are many changes in library-go already. So we'll need to merge them all.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ardaguclu ardaguclu deleted the fake-kms-mode branch January 29, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants