Skip to content

OCPBUGS-56821: Add prometheus alert for image stream import failure#627

Open
jubittajohn wants to merge 1 commit intoopenshift:mainfrom
jubittajohn:image-stream-import-error-alert
Open

OCPBUGS-56821: Add prometheus alert for image stream import failure#627
jubittajohn wants to merge 1 commit intoopenshift:mainfrom
jubittajohn:image-stream-import-error-alert

Conversation

@jubittajohn
Copy link

@jubittajohn jubittajohn commented Oct 13, 2025

Adds prometheus alert ImageStreamImportFailed, for image stream import failure: using the metric openshift_imagestreamcontroller_error_count
Screenshot 2025-10-14 at 13 45 05
Screenshot 2025-11-25 at 16 01 33

  • increase(Counter[Time]) doesn’t count the first value of the counter because increase() always compares with the previous value. For the first time, when the counter has a value of 1, there isn’t any previous value to calculate a difference against. Hence, to account for it, we need to use increase(Counter[Time]) > 0 or Counter > 0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 13, 2025
@openshift-ci-robot
Copy link

@jubittajohn: This pull request references Jira Issue OCPBUGS-56821, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add prometheus alert for image stream import error: using the metric openshift_imagestreamcontroller_error_count

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn
Once this PR has been reviewed and has the lgtm label, please assign sanchezl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jubittajohn jubittajohn force-pushed the image-stream-import-error-alert branch from 33a8c75 to 33c9465 Compare October 14, 2025 16:08
@jubittajohn jubittajohn changed the title OCPBUGS-56821: Add prometheus alert for image stream import error OCPBUGS-56821: Add prometheus alert for image stream import failure Oct 14, 2025
@jubittajohn jubittajohn force-pushed the image-stream-import-error-alert branch from 33c9465 to 988692e Compare October 29, 2025 19:26
@jubittajohn jubittajohn force-pushed the image-stream-import-error-alert branch from 988692e to 3e52884 Compare November 25, 2025 16:23
Signed-off-by: jubittajohn <jujohn@redhat.com>
@jubittajohn jubittajohn force-pushed the image-stream-import-error-alert branch from 3e52884 to 4f77748 Compare November 25, 2025 19:35
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 25, 2025
@openshift-ci-robot
Copy link

@jubittajohn: This pull request references Jira Issue OCPBUGS-56821, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (xiuwang+1@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Adds prometheus alert ImageStreamImportFailed, for image stream import failure: using the metric openshift_imagestreamcontroller_error_count
Screenshot 2025-10-14 at 13 45 05
Screenshot 2025-11-25 at 16 01 33

  • increase(Counter[Time]) doesn’t count the first value of the counter because increase() always compares with the previous value. For the first time, when the counter has a value of 1, there isn’t any previous value to calculate a difference against. Hence, to account for it, we need to use increase(Counter[Time]) > 0 or Counter > 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jubittajohn jubittajohn marked this pull request as ready for review November 25, 2025 21:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial November 25, 2025 21:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

@jubittajohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 4f77748 link true /test e2e-aws-ovn
ci/prow/unit 4f77748 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants