CNF-18941: perfprof: enable exec-cpu-affinity by default (annotation)
#1426
Conversation
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cc @bartwensley |
openshift-merge-robot
added
the
needs-rebase
shajmakh
force-pushed
the
exec-affinity-pp
branch
from
7d801be to
05cf460
Compare
openshift-merge-robot
removed
the
needs-rebase
shajmakh
force-pushed
the
exec-affinity-pp
branch
from
05cf460 to
b7824a4
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
...formanceprofile/controller/performanceprofile/components/machineconfig/machineconfig_test.go
Outdated
Show resolved
Hide resolved
bartwensley
left a comment
bartwensley
left a comment
There was a problem hiding this comment.
This looks good to me (once the tests are passing).
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go
Outdated
Show resolved
Hide resolved
test/e2e/performanceprofile/functests/1_performance/cpu_management.go
Outdated
Show resolved
Hide resolved
shajmakh
force-pushed
the
exec-affinity-pp
branch
4 times, most recently
from
43944ca to
57c2a0e
Compare
|
@bartwensley @Tal-or thanks for the review comments, I addressed them and extended e2e test coverage and filed a PR here for more review flexibility: |
shajmakh
force-pushed
the
exec-affinity-pp
branch
from
57c2a0e to
f2b9f2f
Compare
pkg/performanceprofile/controller/performanceprofile/components/machineconfig/machineconfig.go
Outdated
Show resolved
Hide resolved
shajmakh
force-pushed
the
exec-affinity-pp
branch
from
f2b9f2f to
a9ea0bd
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
shajmakh
force-pushed
the
exec-affinity-pp
branch
from
a9ea0bd to
7c2dd69
Compare
|
filed an ocp bug on that: OCPNODE-3891 |
|
/retest |
shajmakh
changed the title
exec-cpu-affinity by defaultexec-cpu-affinity by default (annotation)
|
/retest |
shajmakh
force-pushed
the
exec-affinity-pp
branch
2 times, most recently
from
ae0f2f5 to
eb07dcf
Compare
|
/test e2e-upgrade |
MarSik
left a comment
MarSik
left a comment
There was a problem hiding this comment.
Just a small naming nit for your consideration. Apart from that lgtm.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MarSik, shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
shajmakh
force-pushed
the
exec-affinity-pp
branch
from
eb07dcf to
16d02b2
Compare
For High-performance configuration, cri-o started supporting exec-cpu-affinity feature and when configured to `first` it provides the ability for exec process to be pinned to the first CPU from the shared-CPUs IF set or to the first one from the islolated set. (see cri-o/cri-o@4dd7fb9) In performance profile, we want to enable this high-performance feature by default, and disable it (legacy) it provides an annotation option. The annotation is there just as a backup in case of bugs getting reported by the consequences of this feature enablement, and should be removed in 2 releases. Run `./hack/render-sync.sh` to update the (no-cluster) e2e tests expected outputs. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
u/s CI stops the run after 2 failures of the same test, which prevents a full run of the tests. The fail-fast option is better be removed in test runs that do not involve node reboots, that way the CI would reflect a full run of the suite which would help us save reruns to see the next failing test. In other words, removing it will reflect all of the failing tests in one run. remove this flag initially for suites of PP that are known to not have reboots. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
The annotation tells crun to manage container's cgroup using the systemd default subgroup behavior. This is meant to reduce the nested cgroups so the container cgroup is placed on the pod/system clice (the parent) rather than creating a cgroup per container. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
|
@shajmakh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
shajmakh
changed the title
exec-cpu-affinity by default (annotation)exec-cpu-affinity by default (annotation)
openshift-ci-robot
added
the
jira/valid-reference
|
@shajmakh: This pull request references CNF-18941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later by @SargunNarula |
|
@shajmakh: Only users can be targets for the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified later @SargunNarula |
openshift-ci-robot
added
verified-later
verified
|
@shajmakh: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7 participants
For High-performance configuration, cri-o started supporting exec-cpu-affinity feature and when configured to
firstit provides the ability for exec process to be pinned to the first CPU from the shared-CPUs IF set or to the first one from the islolated set.(see cri-o/cri-o@4dd7fb9)
In performance profile, we want to enable this high-performance feature by default, and disbale it (legacy) it provides an annotation option.
The annotation is there just as a backup in case of bugs getting reported by the consequences of this feature enablement, and should be removed in 2 releases.