Skip to content

LOG-8090: escape 'new line' (\n) in EventRouter message#3162

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
vparfonov:log8090
Jan 13, 2026
Merged

LOG-8090: escape 'new line' (\n) in EventRouter message#3162
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
vparfonov:log8090

Conversation

@vparfonov
Copy link
Copy Markdown
Contributor

@vparfonov vparfonov commented Nov 24, 2025

Description

This PR addresses a issue where Syslog output format corruption occurs if log messages generated by the Eventrouter contain newline characters (\n), this leads to malformed syslog data.
This fix ensures that the log message payload is properly escaped, preventing the introduction of malformed lines.

When JSON contains \n that becomes a real newline after decoding; sending real newlines in syslog breaks framing and creates split events. This change escapes newline characters (\n) in message payloads so the syslog sink emits a single safe line.

/cc @cahartma @kattz-kawa
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 24, 2025

@vparfonov: This pull request references LOG-8090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR addresses a issue where Syslog output format corruption occurs if log messages generated by the Eventrouter contain newline characters (\n), this leads to malformed syslog data.
This fix ensures that the log message payload is properly escaped, preventing the introduction of malformed lines.

/cc @cahartma @kattz-kawa
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2025
@openshift-ci openshift-ci Bot requested review from Clee2691 and jcantrill November 24, 2025 18:02
@vparfonov
Copy link
Copy Markdown
Contributor Author

/test functional-target

@vparfonov
Copy link
Copy Markdown
Contributor Author

/test e2e-target

@vparfonov vparfonov force-pushed the log8090 branch 2 times, most recently from 1a12219 to 608e639 Compare November 25, 2025 13:18
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 4, 2025

@vparfonov: This pull request references LOG-8090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR addresses a issue where Syslog output format corruption occurs if log messages generated by the Eventrouter contain newline characters (\n), this leads to malformed syslog data.
This fix ensures that the log message payload is properly escaped, preventing the introduction of malformed lines.

When JSON contains \n that becomes a real newline after decoding; sending real newlines in syslog breaks framing and creates split events. This change escapes newline characters (\n) in message payloads so the syslog sink emits a single safe line.

/cc @cahartma @kattz-kawa
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
@jcantrill
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2026

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 3eb044e into openshift:master Jan 13, 2026
7 checks passed
@vparfonov vparfonov deleted the log8090 branch April 30, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/6.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants