Skip to content

OCPBUGS-13547: Remove featureset flag and use only the manifest#735

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
deads2k:render-fe
May 11, 2023
Merged

OCPBUGS-13547: Remove featureset flag and use only the manifest#735
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
deads2k:render-fe

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented May 10, 2023

The manifest now exists in every install and can be used by bootstrapping. The installer passes the arg now, so we can update the operator to only honor the manifest and eliminate interpretation.

peer to openshift/cluster-kube-apiserver-operator#1491

@openshift-ci openshift-ci bot requested review from ingvagabund and mfojtik May 10, 2023 20:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@ingvagabund
Copy link
Member

@deads2k is there a jira card that describes the work?

@deads2k deads2k added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2023
@deads2k
Copy link
Contributor Author

deads2k commented May 11, 2023

Came through as a bug to unrevert the external CCM feature.

last cleanup for command related to external CCM feature unrevert. Description of overall flow here: openshift/enhancements#1373

@ingvagabund
Copy link
Member

/lgtm

@ingvagabund
Copy link
Member

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [deads2k,ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2c45a48 and 2 for PR HEAD 717af5a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit aaf2b4b into openshift:master May 11, 2023
@deads2k deads2k changed the title Remove featureset flag and use only the manifest OCPBUGS-13547: Remove featureset flag and use only the manifest May 16, 2023
@openshift-ci-robot
Copy link

@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state.

Details

In response to this:

The manifest now exists in every install and can be used by bootstrapping. The installer passes the arg now, so we can update the operator to only honor the manifest and eliminate interpretation.

peer to openshift/cluster-kube-apiserver-operator#1491

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants