CNTRLPLANE-2241: Update library-go to get KMS encryption#2033
CNTRLPLANE-2241: Update library-go to get KMS encryption#2033openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughUpdated dependency versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@go.mod`:
- Around line 138-141: The go.mod replace for github.com/ardaguclu/library-go is
missing documentation of why the fork is used and when it can be reverted; add a
concise comment directly above the replace directive that states the purpose
(e.g., temporary patch for KMSEncryption, reference to the specific upstream
issue/PR or commit), the intended revert condition or timeline, and a contact
(Arda Güçlü) or issue/PR URL to track progress; ensure the comment references
the replace target "github.com/ardaguclu/library-go" so future maintainers can
find and remove the fork when upstream is merged.
| replace ( | ||
| github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 | ||
| github.com/openshift/library-go => github.com/ardaguclu/library-go v0.0.0-20260209081556-b8208c8ba998 | ||
| ) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Get the full go.mod file to understand context around the replace block
wc -l go.modRepository: openshift/cluster-kube-apiserver-operator
Length of output: 95
🏁 Script executed:
# Look at the full context around the replace block (lines 130-150)
sed -n '130,150p' go.modRepository: openshift/cluster-kube-apiserver-operator
Length of output: 650
🏁 Script executed:
# Search for any comments or documentation about the ardaguclu/library-go fork
rg -i "ardaguclu|library-go.*fork|replace.*library-go" --type go --type md --type txtRepository: openshift/cluster-kube-apiserver-operator
Length of output: 448
🏁 Script executed:
# Check git history to understand when and why this was added
git log --oneline --all -- go.mod | head -20Repository: openshift/cluster-kube-apiserver-operator
Length of output: 1012
🏁 Script executed:
# Search for any issue references or comments in code related to this fork
rg -i "github\.com/ardaguclu" -A 2 -B 2Repository: openshift/cluster-kube-apiserver-operator
Length of output: 1702
🏁 Script executed:
# Search for any PR or issue references about the ardaguclu fork
rg -i "ardaguclu|library-go.*fork" -B 5 -A 5 --type mdRepository: openshift/cluster-kube-apiserver-operator
Length of output: 67
🏁 Script executed:
# Check for any files mentioning this fork or ardaguclu in comments
rg "ardaguclu" -B 3 -A 3Repository: openshift/cluster-kube-apiserver-operator
Length of output: 2787
🏁 Script executed:
# Look at the specific git commit that introduced the fork in go.mod
git log -p --all -- go.mod | grep -A 20 -B 5 "ardaguclu" | head -100Repository: openshift/cluster-kube-apiserver-operator
Length of output: 67
🏁 Script executed:
# Check if there's any documentation about this fork
find . -type f \( -name "README*" -o -name "CONTRIBUTING*" -o -name "*.md" \) -exec rg -l "library-go\|fork\|ardaguclu" {} \;Repository: openshift/cluster-kube-apiserver-operator
Length of output: 67
🏁 Script executed:
# Check the git blame for the exact line to see when it was added
git blame -L 138,141 go.modRepository: openshift/cluster-kube-apiserver-operator
Length of output: 514
Document why the github.com/ardaguclu/library-go fork is needed and any plan to revert.
The fork is introduced by an approved OpenShift contributor (Arda Güçlü), who is listed as a contact person for the KMSEncryption feature. However, add a brief comment in go.mod or link to an issue explaining the fork's purpose (e.g., temporary patch for a specific commit, waiting for upstream merge) and any timeline to revert to the official dependency. This ensures future maintainers understand the intent and can track the revert.
🤖 Prompt for AI Agents
In `@go.mod` around lines 138 - 141, The go.mod replace for
github.com/ardaguclu/library-go is missing documentation of why the fork is used
and when it can be reverted; add a concise comment directly above the replace
directive that states the purpose (e.g., temporary patch for KMSEncryption,
reference to the specific upstream issue/PR or commit), the intended revert
condition or timeline, and a contact (Arda Güçlü) or issue/PR URL to track
progress; ensure the comment references the replace target
"github.com/ardaguclu/library-go" so future maintainers can find and remove the
fork when upstream is merged.
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Around line 138-140: Add a brief comment directly above the replace directive
that documents why the forked module github.com/ardaguclu/library-go is being
used, reference the tracking issue or PR (e.g., ISSUE- or PR- ID) that
authorizes this temporary fork, specify the revert condition or timebound (e.g.,
upstream PR merge or date), and note the owner responsible for reverting; place
this comment adjacent to the existing replace block so reviewers can see
justification and the planned revert path.
|
It appears that CI is broken, we'll retest once it is fixed. |
|
/retest |
ardaguclu
changed the title
|
@ardaguclu: This pull request references CNTRLPLANE-2241 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@ardaguclu: This pull request references CNTRLPLANE-2241 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm /hold let's wait for the encryption (optional) CI jobs. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest |
|
/retest-required |
|
/test e2e-gcp-operator-serial-ote |
|
/test e2e-gcp-operator-encryption-single-node |
|
/verified by e2e-gcp-operator-encryption-kms ci |
openshift-ci-robot
added
the
verified
|
@gangwgr: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This can be considered a safe change because imported changes can only be used by enabling |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
openshift-merge-bot
Bot
merged commit f6edd25
into
openshift:main
4 participants
This PR is to update library-go to get openshift/library-go#2086