OCPBUGS-55652: Removed PrivateHostedZoneAWS from component

[Thealisyed]

Removed PrivateHostedZoneAWS from cluster-ingress-operator as it is no longer needed

[openshift-ci-robot]

@Thealisyed: This pull request references Jira Issue OCPBUGS-55652, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Removed PrivateHostedZoneAWS from cluster-ingress-operator as it is no longer needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[lihongan]

/jira refresh

[openshift-ci-robot]

@lihongan: This pull request references Jira Issue OCPBUGS-55652, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Thealisyed]

okd-scos-e2e-aws-ovn: failed to wait for importing imagestreamtags
e2e-aws-ovn-single-node: failed cluster creation
e2e-aws-operator + e2e-gcp-operator: failed to get vap and DNS record
/retest

[Thealisyed]

okd-scos-e2e-aws-ovn: when using openshift ovn-kubernetes created using UserDefinedNetwork is isolated from the default network with L2 primary UDN
e2e-gcp-operator: TestAll/parallel/TestMTLSWithCRLs/large-crl
e2e-aws-operator: TestAll/parallel/TestAWSELBConnectionIdleTimeout + TestAll/serial/TestGatewayAPI/testOperatorDegradedCondition

/retest

[Thealisyed]

e2e-aws-operator: Error connecting to test-hostname-fs5vs.gws.ci-op-grbd9ghg-43abb.origin-ci-int-aws.dev.rhcloud.com: context deadline exceeded

/retest

[Thealisyed]

Seems flaky, will try one more time
e2e-aws-operator: message: "One or more status conditions indicate unavailable: LoadBalancerReady=False (LoadBalancerPending: The LoadBalancer service is pending)"
TestAll/serial/TestIngressControllerCustomEndpoints

/retest

[Miciah]

/approve

But please expand the commit message.

• Add a reference to https://issues.redhat.com/browse/OCPBUGS-55652 to the commit message.
• Clarify that you are removing the featuregate check only; the feature itself is not being removed.
• Mention that the featuregate was introduced as TPNU in OpenShift 4.14 and promoted to Default in the same release.
• For bonus points, you can add a breadcrumb to the commit that introduced the featuregate: "Follow-up to commit 7251aaa."

There's some quirky history here that probably isn't necessary to put in the commit message, but in case anyone is curious:

• Featuregate was added as TPNU here: openshift/api@8193b05
• Featuregate was promoted to Default here: openshift/api@edae94d
• The feature was backported to OpenShift 4.13, but the featuregate was not: [release-4.13] OCPSTRAT-659: DNS: Add awsPrivateHostedZoneRole api#1529 (comment)

Annoyingly, the featuregate definitions were moved all around and restructured, which makes it difficult to trace the history.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

Thanks, the commit message looks better. A couple more suggestions:

Remove PrivateHostedZoneAWS feature gate check from cluster-ingress-operator.

Please keep the first line within 50 chars, and don't end it with a full stop.

The feature itself (support for AWS Private Hosted Zones) remains, only the feature gate check is being removed.
The PrivateHostedZoneAWS feature gate was originally introduced as TPNU in OpenShift 4.14 and was promoted to Default in the same release.

Please wrap the commit message body at 72 characters.

Since it is now always enabled, the feature gate check is redundant.

It is more accurate to say that the feature gate has been enabled by default for over 3 releases, and so it is scheduled to be removed imminently. Technically it could still be disabled with a custom feature set, and as long as the feature gate exists, we should respect it.

By the way, we should have an openshift/api PR ready to go to remove the feature gate as soon as this cluster-ingress-operator PR merges. Could you go ahead and post that PR, and link it in this PR's description?

[Miciah]

/assign

[candita]

/assign @grzpiotrowski

[Thealisyed]

This is a follow up PR in openshift/api, removing the PrivateHostedZoneAWS feature gate from features/features.go

[melvinjoseph86]

/retest-required

[melvinjoseph86]

mjoseph@mjoseph-mac Downloads % oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.20.0-0-2025-05-26-050211-test-ci-ln-kyvjfwt-latest True False 45m Cluster version is 4.20.0-0-2025-05-26-050211-test-ci-ln-kyvjfwt-latest

mjoseph@mjoseph-mac Downloads %
mjoseph@mjoseph-mac Downloads %
mjoseph@mjoseph-mac Downloads % oc get featuregates.config.openshift.io cluster -oyaml
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
annotations:
include.release.openshift.io/self-managed-high-availability: "true"
creationTimestamp: "2025-05-26T05:19:03Z"
generation: 1
name: cluster
resourceVersion: "684"
uid: 50d55875-bdba-4cef-bd9b-153430884429
spec: {}
status:
featureGates:

• disabled:
  • name: AWSClusterHostedDNS
  • name: AWSDedicatedHosts
  • name: AutomatedEtcdBackup
  • name: AzureMultiDisk
  • name: BootcNodeManagement
  • name: ClusterAPIInstall
  • name: ClusterAPIInstallIBMCloud
  • name: ClusterMonitoringConfig
  • name: ClusterVersionOperatorConfiguration
  • name: DNSNameResolver
  • name: DualReplica
  • name: DyanmicServiceEndpointIBMCloud
  • name: DynamicResourceAllocation
  • name: EtcdBackendQuota
  • name: EventedPLEG
  • name: Example
  • name: Example2
  • name: ExternalOIDC
  • name: ExternalOIDCWithUIDAndExtraClaimMappings
  • name: GCPClusterHostedDNS
  • name: GCPCustomAPIEndpoints
  • name: HighlyAvailableArbiter
  • name: ImageStreamImportMode
  • name: IngressControllerDynamicConfigurationManager
  • name: InsightsConfig
  • name: InsightsConfigAPI
  • name: InsightsOnDemandDataGather
  • name: InsightsRuntimeExtractor
  • name: KMSEncryptionProvider
  • name: MachineAPIMigration
  • name: MachineAPIOperatorDisableMachineHealthCheckController
  • name: MachineConfigNodes
  • name: ManagedBootImagesvSphere
  • name: MaxUnavailableStatefulSet
  • name: MinimumKubeletVersion
  • name: MixedCPUsAllocation
  • name: MultiArchInstallAzure
  • name: NewOLMCatalogdAPIV1Metas
  • name: NewOLMOwnSingleNamespace
  • name: NewOLMPreflightPermissionChecks
  • name: NewOLMWebhookProviderOpenshiftServiceCA
  • name: NodeSwap
  • name: NutanixMultiSubnets
  • name: OVNObservability
  • name: PinnedImages
  • name: PlatformOperators
  • name: RouteAdvertisements
  • name: SELinuxMount
  • name: ShortCertRotation
  • name: SignatureStores
  • name: SigstoreImageVerification
  • name: SigstoreImageVerificationPKI
  • name: TranslateStreamCloseWebsocketRequests
  • name: UpgradeStatus
  • name: VSphereConfigurableMaxAllowedBlockVolumesPerNode
  • name: VSphereHostVMGroupZonal
  • name: VSphereMixedNodeEnv
  • name: VSphereMultiDisk
  • name: VSphereMultiNetworks
  • name: VolumeAttributesClass
  • name: VolumeGroupSnapshot
    enabled:
  • name: AWSEFSDriverVolumeMetrics
  • name: AdditionalRoutingCapabilities
  • name: AdminNetworkPolicy
  • name: AlibabaPlatform
  • name: AzureWorkloadIdentity
  • name: BuildCSIVolumes
  • name: CPMSMachineNamePrefix
  • name: ChunkSizeMiB
  • name: ConsolePluginContentSecurityPolicy
  • name: GCPLabelsTags
  • name: GatewayAPI
  • name: GatewayAPIController
  • name: HardwareSpeed
  • name: IngressControllerLBSubnetsAWS
  • name: KMSv1
  • name: ManagedBootImages
  • name: ManagedBootImagesAWS
  • name: MetricsCollectionProfiles
  • name: MultiArchInstallAWS
  • name: NetworkDiagnosticsConfig
  • name: NetworkLiveMigration
  • name: NetworkSegmentation
  • name: NewOLM
  • name: NodeDisruptionPolicy
  • name: OnClusterBuild
  • name: OpenShiftPodSecurityAdmission
  • name: PersistentIPsForVirtualization
  • name: ProcMountType
  • name: RouteExternalCertificate
  • name: ServiceAccountTokenNodeBinding
  • name: SetEIPForNLBIngressController
  • name: UserNamespacesPodSecurityStandards
  • name: UserNamespacesSupport
  • name: ValidatingAdmissionPolicy
    version: 4.20.0-0-2025-05-26-050211-test-ci-ln-kyvjfwt-latest

[melvinjoseph86]

/label qe-approved

[Thealisyed]

failed cluster install

/retest

[Thealisyed]

/retest

[Thealisyed]

/retest

[Miciah]

Thanks, @Thealisyed!
/lgtm

@melvinjoseph86, are your results from testing the combination of this PR with openshift/api#2338? The cluster-ingress-operator PR itself doesn't remove the featuregate from the clusterversion.

/hold
for @melvinjoseph86's response and @grzpiotrowski's review.

[melvinjoseph86]

@melvinjoseph86, are your results from testing the combination of this PR with openshift/api#2338? The cluster-ingress-operator PR itself doesn't remove the featuregate from the clusterversion.
Yes @Miciah i clubbed both this PR with API PR in the clusterbot

[grzpiotrowski]

/lgtm
/unhold

[openshift-ci]

@Thealisyed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@Thealisyed: Jira Issue OCPBUGS-55652: Some pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#1230

The following pull requests linked via external trackers have not merged:

• openshift/api#2338 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-55652 has not been moved to the MODIFIED state.

Details

In response to this:

Removed PrivateHostedZoneAWS from cluster-ingress-operator as it is no longer needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.20.0-202506042244.p0.gbe41be0.assembly.stream.el9.
All builds following this will include this PR.