NO-JIRA: Set admission failure policy to Ignore

[JoelSpeed]

Currently we are sometimes blocking cluster bootstrap. This must be set to Ignore while the bootstrap API server cannot talk to the pod network.

In the long term, we will revert this to Fail once openshift/enhancements#1941 is accepted and implemented

Summary by CodeRabbit

• Bug Fixes
  • Updated webhook configurations to allow cluster bootstrap to complete without blocking during system initialization.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@JoelSpeed: This pull request explicitly references no jira issue.

Details

In response to this:

Currently we are sometimes blocking cluster bootstrap. This must be set to Ignore while the bootstrap API server cannot talk to the pod network.

In the long term, we will revert this to Fail once openshift/enhancements#1941 is accepted and implemented

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between b2d9212 and faf0e8d.

📒 Files selected for processing (2)

• pkg/controllers/crdcompatibility/bindata/assets/compatibility-requirements-compatibility-requirement-webhook.yaml
• pkg/controllers/crdcompatibility/bindata/assets/compatibility-requirements-custom-resource-definition-webhook.yaml

---

📝 Walkthrough

Walkthrough

Two admission webhook configurations update their failurePolicy setting from Fail to Ignore, accompanied by explanatory comments indicating this is a temporary measure with planned restoration after addressing related enhancements.

Changes

Cohort / File(s)	Summary
Webhook Configuration Updates pkg/controllers/crdcompatibility/bindata/assets/compatibility-requirements-compatibility-requirement-webhook.yaml, pkg/controllers/crdcompatibility/bindata/assets/compatibility-requirements-custom-resource-definition-webhook.yaml	Changed failurePolicy from Fail to Ignore with inline comments explaining the temporary rationale and future restoration plan.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A webhook needs a softer touch today,
Fail becomes Ignore, clearing the way,
With comments wise, the path is known,
Bootstrap smooth, in fields we've sown! 🌱

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the primary change: modifying admission webhook failure policies from Fail to Ignore across two webhook configuration files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mdbooth]

It's safe to say everybody hates this, but it's pragmatic for now.

/approve
/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-capi-techpreview
/test e2e-aws-ovn
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-aws-ovn-techpreview
/test e2e-aws-ovn-techpreview-upgrade
/test e2e-azure-capi-techpreview
/test e2e-azure-ovn-techpreview
/test e2e-azure-ovn-techpreview-upgrade
/test e2e-gcp-capi-techpreview
/test e2e-gcp-ovn-techpreview
/test e2e-metal3-capi-techpreview
/test e2e-openstack-capi-techpreview
/test e2e-openstack-ovn-techpreview
/test e2e-vsphere-capi-techpreview
/test regression-clusterinfra-aws-ipi-techpreview-capi

[JoelSpeed]

/verified by CI

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[theobarberbany]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mdbooth,theobarberbany]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/retest-required

[openshift-ci]

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-techpreview	faf0e8d	link	false	/test e2e-azure-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

The ci/prow/e2e-azure-ovn-techpreview job is optional and the failure was unrelated and due to cloud quotas

e2e-openstack-ovn-techpreview is a permafailing job ATM: https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-cluster-capi-operator-main-e2e-openstack-ovn-techpreview

/override ci/prow/e2e-openstack-ovn-techpreview

[openshift-ci]

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-openstack-ovn-techpreview

Details

In response to this:

The ci/prow/e2e-azure-ovn-techpreview job is optional and the failure was unrelated and due to cloud quotas

e2e-openstack-ovn-techpreview is a permafailing job ATM: https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-cluster-capi-operator-main-e2e-openstack-ovn-techpreview

/override ci/prow/e2e-openstack-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.