[release-4.21] OCPBUGS-74418: Add KMS test scenarios by gangwgr · Pull Request #844 · openshift/cluster-authentication-operator

gangwgr · 2026-02-24T11:10:13Z

Backport kms test cases to 4.21

coderabbitai · 2026-02-24T11:10:22Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-02-24T11:10:34Z

@gangwgr: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport kms test cases to 4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-24T11:10:45Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: gangwgr.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@gangwgr: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.21.z) matches configured target version for branch (4.21.z)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

release note type set to "Release Note Not Required"

dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))

dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0

bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport kms test cases to 4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ardaguclu · 2026-02-25T04:45:59Z

@gangwgr these need to be fixed;

vet: test/e2e-encryption-kms/encryption_kms_test.go:80:132: undefined: library.SupportedStaticEncryptionProviders
make: *** [vendor/github.com/openshift/build-machinery-go/make/targets/golang/verify-update.mk:27: verify-govet] Error 1
diff -Naup vendor/github.com/openshift/api/authorization/v1/zz_generated.crd-manifests/0000_03_config-operator_01_rolebindingrestrictions.crd.yaml bindata/oauth-openshift/authorization.openshift.io_rolebindingrestrictions.yaml

I think you may need to run make update and run goimport on encryption_kms_test.go

gangwgr · 2026-02-25T06:16:07Z

/retest

openshift-ci · 2026-02-25T09:51:09Z

@gangwgr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator-encryption-rotation	`8e2fc3e`	link	true	`/test e2e-gcp-operator-encryption-rotation`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

p0lyn0mial · 2026-03-03T12:02:38Z

go.mod

 )

+// PR 2131: OCPBUGS-74418 add KMS test helpers (release-4.21)
+replace github.com/openshift/library-go => github.com/gangwgr/library-go v0.0.0-20260225055023-b41850fe248b


this needs to be updated.

/hold

p0lyn0mial · 2026-03-03T12:04:04Z

/approve
/label backport-risk-assessed

We don't need an SBAR for the TP backport.

This PR matches openshift/cluster-kube-apiserver-operator#2054 and openshift/cluster-openshift-apiserver-operator#656

/assign @liouk

liouk · 2026-03-03T14:07:51Z

test/e2e-encryption-kms/main_test.go

+
+	tests := *realPtrToTests
+
+	rand.Seed(time.Now().UnixNano())


nit: rand.Seed() is a no-op on 1.24, which is the current go version unless I'm mistaken -- we could drop this.

liouk · 2026-03-03T14:10:12Z

test/e2e-encryption-kms/main_test.go

+)
+
+func TestMain(m *testing.M) {
+	randomizeTestOrder(m)


Instead of randomizing manually, I wonder whether we could leverage go's -test.shuffle -- then we wouldn't have to resort to such hacks, as they're quite fragile. Has this been considered?

liouk · 2026-03-03T14:11:16Z

test/e2e-encryption-kms/encryption_kms_test.go

+
+// TestKMSEncryptionOnOff tests KMS encryption on/off cycle.
+// This test:
+// 2. Creates a test OAuth access token (TokenOfLife)


nit: list numbering starts at 2

openshift-ci · 2026-03-03T15:08:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr, p0lyn0mial
Once this PR has been reviewed and has the lgtm label, please ask for approval from liouk. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gangwgr changed the title ~~Backport kms cases 4.21~~ [release-4.21] OCPBUGS-74418: Add KMS test scenarios Feb 24, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 24, 2026

openshift-ci bot requested review from ibihim and liouk February 24, 2026 11:12

gangwgr force-pushed the backport-kms-cases-4.21 branch 5 times, most recently from 573e9c0 to 35e6e8e Compare February 24, 2026 12:20

gangwgr force-pushed the backport-kms-cases-4.21 branch from 35e6e8e to e03203f Compare February 25, 2026 06:05

gangwgr force-pushed the backport-kms-cases-4.21 branch from e03203f to e0cd1a5 Compare February 25, 2026 06:20

p0lyn0mial reviewed Mar 3, 2026

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026

openshift-ci bot assigned liouk Mar 3, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 3, 2026

liouk reviewed Mar 3, 2026

View reviewed changes

gangwgr force-pushed the backport-kms-cases-4.21 branch from e0cd1a5 to 3b02bba Compare March 3, 2026 15:06

gangwgr force-pushed the backport-kms-cases-4.21 branch 2 times, most recently from e0cd1a5 to d44ddaf Compare March 3, 2026 15:15

gangwgr added 2 commits March 3, 2026 20:58

Add KMS encryption test scenarios

c9a3570

Vendor library-go KMS test helpers

e1f994b

gangwgr force-pushed the backport-kms-cases-4.21 branch from d44ddaf to e1f994b Compare March 3, 2026 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.21] OCPBUGS-74418: Add KMS test scenarios#844

[release-4.21] OCPBUGS-74418: Add KMS test scenarios#844
gangwgr wants to merge 2 commits intoopenshift:release-4.21from
gangwgr:backport-kms-cases-4.21

gangwgr commented Feb 24, 2026

Uh oh!

coderabbitai bot commented Feb 24, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Feb 24, 2026

Uh oh!

openshift-ci bot commented Feb 24, 2026

Uh oh!

ardaguclu commented Feb 25, 2026

Uh oh!

gangwgr commented Feb 25, 2026

Uh oh!

openshift-ci bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

p0lyn0mial Mar 3, 2026

Uh oh!

p0lyn0mial commented Mar 3, 2026

Uh oh!

liouk Mar 3, 2026

Uh oh!

liouk Mar 3, 2026

Uh oh!

liouk Mar 3, 2026

Uh oh!

openshift-ci bot commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gangwgr commented Feb 24, 2026

Uh oh!

coderabbitai bot commented Feb 24, 2026

Review skipped

Uh oh!

openshift-ci-robot commented Feb 24, 2026

Uh oh!

openshift-ci bot commented Feb 24, 2026

Uh oh!

ardaguclu commented Feb 25, 2026

Uh oh!

gangwgr commented Feb 25, 2026

Uh oh!

openshift-ci bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

p0lyn0mial Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented Mar 3, 2026

Uh oh!

liouk Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

liouk Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

liouk Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci bot commented Feb 25, 2026 •

edited

Loading